k9s icon indicating copy to clipboard operation
k9s copied to clipboard

feat(delete/node): challenge deletion by text phrase

Open hansbogert opened this issue 2 years ago • 8 comments

A really simplistic change to not get burned by an accidental deletion of a node.

This is after 15min of looking through the k9s code and getting the functionality in asap; meant as inspiration for https://github.com/derailed/k9s/issues/1016

Help to make this a production ready change would be welcome.

image

hansbogert avatar Oct 14 '23 08:10 hansbogert

FYI This PR might resolve #2076

especially if this behavior is opt-in via config toggle or cli argument

jtcressy avatar Dec 05 '23 21:12 jtcressy

Just rebased to master, @derailed when you have the time, can you give a final verdict and/or merge this?

hansbogert avatar Dec 10 '23 10:12 hansbogert

@derailed is there something I can do in regards to the 'tlc' tag?

hansbogert avatar Dec 31 '23 12:12 hansbogert

@hansbogert Yes please take a peek at the conflicts with the latest drop. Thank you!

derailed avatar Jan 04 '24 06:01 derailed

@derailed Updated.

hansbogert avatar Jan 06 '24 14:01 hansbogert

@derailed Gentle nudge, I have to keep rebasing/conflict-resolve. Is the current change good enough?

hansbogert avatar Feb 14 '24 07:02 hansbogert

@derailed 👼

hansbogert avatar Apr 13 '24 20:04 hansbogert

@derailed is this getting in?

hansbogert avatar Jul 21 '24 09:07 hansbogert