k9s icon indicating copy to clipboard operation
k9s copied to clipboard

Add condition for setting current and target values from AverageValue on HPA renderer

Open jpereiramp opened this issue 3 years ago • 2 comments

Fixes Issue #1440.

The proposed fix is to check for non-nil, non-zero current and target AverageValue values and, when found, use those when building the entry for the TARGETS% column when rendering an hpa object.

When no non-nil, non-zero AverageValue is found, we fallback to the existing case where the Value fields are used.

There are test cases for both Value and AverageValue cases.

jpereiramp avatar Jan 26 '22 06:01 jpereiramp

@jpereiramp Thank you for this update! Looks like we have some conflicts...

derailed avatar Nov 12 '23 19:11 derailed