cauldron icon indicating copy to clipboard operation
cauldron copied to clipboard

Standardize typography

Open schne324 opened this issue 4 years ago • 1 comments

A new typographic scale will be implemented in a non-breaking manner with #1570. This PR will implement the changes to make them global and/or implementing typographic components. The nature of the change may have potential downstream impacts, so there is a possibility of a breaking change.

This will include the following changes:

Designs

https://www.figma.com/design/CEFVdiecqDjLSjhorjHUzI/Product-Foundations--Cauldron--Library?node-id=1274-1563&m=dev

Setting Baselines

We've started to establish baselines in typography: https://github.com/dequelabs/cauldron/blob/develop/packages/styles/typography.css using design system tokens.

We to determine:

  • [ ] Are the any existing font-families that we need to remove (or add)?
  • [ ] How to connect the typographic scale with existing components?
    • [ ] Do we build it into our base css? (Note: there are a number of competing overrides in products)
    • [ ] Do we build it into typography components? (<Typography text="h1" />, etc., material has an example of this.
      • There has also been some discussions in the front end guild: https://github.com/dequelabs/frontend-guild/discussions/8

schne324 avatar Nov 09 '21 20:11 schne324

Discussed this during the most recent design sync meeting, we have a bunch of roadblocks to getting this implemented but wanted to discuss how we can make some movement on this front, including the following topics:

Notes

  • Use the front-end guild to make some movement on this including
    • Visual regression testing
    • Tracking when and where Cauldron is used and overridden
  • Reaching out to our accessibility leadership, getting them involved in helping us define and prioritize the problem
  • Implementing variants to have targeted approaches
  • Implementing feature flags for targeted approaches
  • Do it anyway (just for line-height)
  • Typography components

scurker avatar Aug 19 '25 19:08 scurker