cauldron icon indicating copy to clipboard operation
cauldron copied to clipboard

Published 20 hours ago • verified publisher icon dequelabs

test: switch options menu tests to react testing library

Open lsprr opened this issue 10 months ago • 2 comments

Issue #1159

This PR switches the Options Menu tests to React Testing Library.

Validation steps

  • Run yarn test
  • See that there are coverage percentages in the table
  • Verify that the tests are converted properly

lsprr avatar Apr 23 '24 05:04 lsprr

This pull request is automatically being deployed by Amplify Hosting (learn more).

Access this pull request here: https://pr-1461.d15792l1n26ww3.amplifyapp.com

aws-amplify-us-east-1[bot] avatar Apr 23 '24 05:04 aws-amplify-us-east-1[bot]

Hi @scurker

I encountered some challenges getting it to cooperate seamlessly with the delegated events and click outside listener. Despite various attempts, I couldn't resolve it. I strongly advocate for testing in a full browser environment with UI testing, as I believe it's entirely feasible to test this functionality. Therefore, I've omitted the test events and click outside listener from this test.

lsprr avatar Apr 23 '24 05:04 lsprr

@lsprr thanks for your work here! I've taken this over and moved the commits over to #1543, so closing this PR

scurker avatar Jun 26 '24 19:06 scurker