axe-core icon indicating copy to clipboard operation
axe-core copied to clipboard

Mis-identification of landmark role, false positive for unique AccName

Open MelSumner opened this issue 9 months ago • 2 comments

Product

axe-core

Product Version

4.10.2

Latest Version

  • [x] I have tested the issue with the latest version of the product

Issue Description

Expectation

I expect landmark roles to be identified correctly. I expect values for aria-labelledby to be correctly differentiated.

Actual

Screenshot: Image

I have a section element with the role of tabpanel. There are several tabpanels, and they are all given a unique accessible name through the aria-labelledby attribute. Visible in the screenshot are those values.

  1. My first issue is that an element with the role of tabpanel is not a landmark element.
  2. My second issue is that I did not expect to receive an error about unique AccNames, when the values for each aria-labelledby attribute are unique ID values. However, if the tool is actually replacing the ID with the text value for that ID, then this would not be a false positive (since this is on a page with several demo versions of a component).

How to Reproduce

Hopefully the attached screenshot is enough information to reproduce the issue. If not, please let me know.

MelSumner avatar Mar 07 '25 15:03 MelSumner

Thanks for the issue.

  1. Yes, this appears to be a bug in our code (specifically in our matcher where we say if a section element has an accessible name it's a landmark and ignore the actual role of the element). The section should not be counted as a landmark in this case.
  2. This is expected behavior as the landmark rule looks at the accessible name of the landmarks to make sure the accessible names are unique.

straker avatar Mar 07 '25 16:03 straker

Ok, thank you for confirming!

MelSumner avatar Mar 07 '25 16:03 MelSumner