fix(td-ref-attr): report headers attribute referencing other <td> elements as unsupported
Fix for the header attribute check. The check will report cells that references other <td> elements. Added unit and integrations tests as requested in corresponding issue.
Closes: #3987
Please, let me know if there are any changes needed. Thanks! @WilcoFiers and @straker for vis.
@engineerklimov Heyya, apologies about the delays. Lots to do. I'll try to get to it within the week.
Appreciate your response, Sir Looking forward to the review
I have NVDA + Firefox and JAWS + Chrome, can you describe what tests need to be done?
I'm going to change this PR title to "feat". This PR makes the rule stricter, we can't put that in a patch release.
@WilcoFiers I did all changes, the only thing left is locales updates. Can you check error messages? If they are fine i will update all translations.
It looks like
fmt_checkis still showing 1 error to resolve, + it'd be good to do annpm run buildto re-generate/locales/_template.jsonto match the most recent rule text update.Other than those, this looks good to me!
I did updates you requested, there is problem with @WilcoFiers test case with wrong closing tag. Prettier shows error here somehow line ignore not working.
So i updated .prettierignore, let me know if there is better way to fix it.
I pursue your approvals guys @WilcoFiers @dbjorge @straker :slightly_smiling_face:
(@WilcoFiers , once you've done the security review for my editorial commit, feel free to merge)
For the bookx: Reviewed for security.