axe-core icon indicating copy to clipboard operation
axe-core copied to clipboard

fix(td-ref-attr): report headers attribute referencing other <td> elements as unsupported

Open engineerklimov opened this issue 1 year ago • 1 comments

Fix for the header attribute check. The check will report cells that references other <td> elements. Added unit and integrations tests as requested in corresponding issue.

Closes: #3987

engineerklimov avatar Sep 26 '24 10:09 engineerklimov

Please, let me know if there are any changes needed. Thanks! @WilcoFiers and @straker for vis.

engineerklimov avatar Oct 16 '24 18:10 engineerklimov

@engineerklimov Heyya, apologies about the delays. Lots to do. I'll try to get to it within the week.

WilcoFiers avatar Oct 23 '24 16:10 WilcoFiers

Appreciate your response, Sir Looking forward to the review

engineerklimov avatar Oct 23 '24 17:10 engineerklimov

I have NVDA + Firefox and JAWS + Chrome, can you describe what tests need to be done?

engineerklimov avatar Oct 30 '24 15:10 engineerklimov

I'm going to change this PR title to "feat". This PR makes the rule stricter, we can't put that in a patch release.

WilcoFiers avatar Nov 01 '24 11:11 WilcoFiers

@WilcoFiers I did all changes, the only thing left is locales updates. Can you check error messages? If they are fine i will update all translations.

engineerklimov avatar Nov 01 '24 17:11 engineerklimov

It looks like fmt_check is still showing 1 error to resolve, + it'd be good to do an npm run build to re-generate /locales/_template.json to match the most recent rule text update.

Other than those, this looks good to me!

I did updates you requested, there is problem with @WilcoFiers test case with wrong closing tag. Prettier shows error here somehow line ignore not working.

image

So i updated .prettierignore, let me know if there is better way to fix it.

engineerklimov avatar Nov 15 '24 15:11 engineerklimov

I pursue your approvals guys @WilcoFiers @dbjorge @straker :slightly_smiling_face:

engineerklimov avatar Nov 19 '24 14:11 engineerklimov

(@WilcoFiers , once you've done the security review for my editorial commit, feel free to merge)

dbjorge avatar Nov 19 '24 19:11 dbjorge

For the bookx: Reviewed for security.

WilcoFiers avatar Nov 19 '24 20:11 WilcoFiers