axe-core
axe-core copied to clipboard
feat(aria-prohibited-attr): add support fallback role
This PR adds fallback role support to aria-prohibited-attr. For example, <div role="foo img" aria-label="..."> is legal.
At this time, I do not plan to add fallback roles support for other checks.
Related:
- https://github.com/dequelabs/axe-core/issues/3768
Closes:
Thanks for the pr. Unfortunately with axe-con quickly approaching we won't be able to look at this any time soon. After axe-con we'll be able to revisit this again.
Thanks for the pr. Unfortunately with axe-con quickly approaching we won't be able to look at this any time soon. After axe-con we'll be able to revisit this again.
Thank you for providing the information. I wish you a successful event, as in previous years. Please let me know if you need any changes are necessary.
@WilcoFiers
Thank you for your review.
Would you mind adding one or two test cases to
test/integration/rules/aria-prohibited-attr/aria-prohibited-attr.htmland its.jsonfile as well?
I have added a few tests to test/integration/rules/aria-prohibited-attr/aria-prohibited-attr.html in https://github.com/dequelabs/axe-core/pull/4325/commits/b405042a5b58e6a2b88192538d6119678c44bf7e.
Although I need to update this branch to pass CI tests, it may be better to wait until https://github.com/dequelabs/axe-core/pull/4354 is merged.