axe-core icon indicating copy to clipboard operation
axe-core copied to clipboard

feat(aria-prohibited-attr): add support fallback role

Open takenspc opened this issue 1 year ago • 3 comments

This PR adds fallback role support to aria-prohibited-attr. For example, <div role="foo img" aria-label="..."> is legal.

At this time, I do not plan to add fallback roles support for other checks.

Related:

  • https://github.com/dequelabs/axe-core/issues/3768

Closes:

takenspc avatar Feb 05 '24 07:02 takenspc

Thanks for the pr. Unfortunately with axe-con quickly approaching we won't be able to look at this any time soon. After axe-con we'll be able to revisit this again.

straker avatar Feb 07 '24 17:02 straker

Thanks for the pr. Unfortunately with axe-con quickly approaching we won't be able to look at this any time soon. After axe-con we'll be able to revisit this again.

Thank you for providing the information. I wish you a successful event, as in previous years. Please let me know if you need any changes are necessary.

takenspc avatar Feb 08 '24 00:02 takenspc

@WilcoFiers

Thank you for your review.

Would you mind adding one or two test cases to test/integration/rules/aria-prohibited-attr/aria-prohibited-attr.html and its .json file as well?

I have added a few tests to test/integration/rules/aria-prohibited-attr/aria-prohibited-attr.html in https://github.com/dequelabs/axe-core/pull/4325/commits/b405042a5b58e6a2b88192538d6119678c44bf7e.

Although I need to update this branch to pass CI tests, it may be better to wait until https://github.com/dequelabs/axe-core/pull/4354 is merged.

takenspc avatar Mar 05 '24 11:03 takenspc