anet icon indicating copy to clipboard operation
anet copied to clipboard

`fetchData` is being called twice on Daily Rollup

Open nickjs opened this issue 8 years ago • 4 comments

nickjs avatar Feb 10 '17 05:02 nickjs

Relevant code snippet in Page:

	componentWillReceiveProps(props, nextContext) {
		if (props !== this.props) {
			this.loadData(props)
		} else if (this.context && (this.context !== nextContext)) {
			this.loadData(props)
		}

	}

	componentDidMount() {
		setMessages(this.props, this.state)
		this.loadData(this.props)
	}

NickHeiner avatar Mar 01 '17 22:03 NickHeiner

@erincd if we are behind schedule, you may wish to cut this one. It's annoying to us devs that it happens, and it may make the end-user experience a bit slower because it's extra network traffic. But aside from that, I'm not sure that this has a user-facing impact.

NickHeiner avatar Mar 03 '17 15:03 NickHeiner

ahh thanks nick. I was literally just coming here to let you guys know I don't have a sense for the priority here. I'll push it two sprints out and we can revisit.

erincd avatar Mar 05 '17 18:03 erincd