deps.rs icon indicating copy to clipboard operation
deps.rs copied to clipboard

higher required then latest gives "out of date"

Open rukai opened this issue 6 years ago • 3 comments

I use [patch.crates-io] to override the crate used in my project when I make a bug fix that is waiting to be upstreamed. However this results in a higher version then is listed on crates.io causing the deps.rs listing to say "out of date", when it should really say "up to date".

Occurs on vulkano-win here: https://deps.rs/repo/github/rukai/pf_sandbox

rukai avatar Feb 13 '18 12:02 rukai

Hmm, yeah, that's an interesting problem!

Technically when a dependency is "patched" through [patch.crates-io] there is no easy way to figure out whether that patch is strictly less or more recent than the last published version of the dependency (DVCS being what it is, it could even be both less and more recent).

I'm inclined to say that maybe patched dependencies shouldn't count either way, but rather be tracked as "patched" (as opposed to "outdated" or "up to date").

There is similar logic today for dependencies that are sourced directly from a git repository, e.g.

[dependency.foo]
git = ...

Would that kind of solution work for you? Effectively it would exclude patched dependencies from weighting in for the dependency status, and an "up to date" status would be achievable even in the presence of patched dependencies.

srijs avatar Feb 14 '18 06:02 srijs

That sounds great!

rukai avatar Feb 14 '18 07:02 rukai

This situation also happens when deps.rs cannot detect the latest version on crates.io because of cache.

(The latest version on crates.io is 0.15.1 in this image) deps.rs screenshot

picoHz avatar May 15 '22 03:05 picoHz