symplify
symplify copied to clipboard
[ConfigTransformer] fix conflicts with --dry-run and --no-interaction
-n alias conflicts with \Symfony\Component\Console\Application::getDefaultInputDefinition
fix #4326
What about disablind the -n
option from getDefaultInputDefinition()
? We don't use it anyway and this shortcut comes handy.
I just push a dirty fix, what did you think about?
I need to find a more cleaner way to do
I think this look good. How does it perform when you change it locally?
Btw, could you add a comment there about "why"? Just so we don't remove it and know it was a "-n" option blocker :)
I change the way to achieve this, with more granular behavior
I had to change LightKernelInterface
, don't know if it's a good idea
And also put some comments
Let me know if it's a good approach
Thanks for time and feedback on this, I really appreciate :)
Hi, thanks on working on this so quickly :)
I think the approach in Application::getDefaultInputDefinition()
is better, because it's closer to the point of origin of this problem.
The Kernel is quite abstract place and might be hard to connect the dots.
Could you move it to the Application
one?
I move back to the KernelBootAndApplicationRun
with simple implementation (and comment).
Thank you :clap: