symplify icon indicating copy to clipboard operation
symplify copied to clipboard

[ConfigTransformer] fix conflicts with --dry-run and --no-interaction

Open bchatard opened this issue 1 year ago • 3 comments

-n alias conflicts with \Symfony\Component\Console\Application::getDefaultInputDefinition

fix #4326

bchatard avatar Aug 10 '22 11:08 bchatard

What about disablind the -n option from getDefaultInputDefinition()? We don't use it anyway and this shortcut comes handy.

TomasVotruba avatar Aug 10 '22 12:08 TomasVotruba

I just push a dirty fix, what did you think about?

I need to find a more cleaner way to do

bchatard avatar Aug 10 '22 13:08 bchatard

I think this look good. How does it perform when you change it locally?

Btw, could you add a comment there about "why"? Just so we don't remove it and know it was a "-n" option blocker :)

TomasVotruba avatar Aug 10 '22 15:08 TomasVotruba

I change the way to achieve this, with more granular behavior I had to change LightKernelInterface, don't know if it's a good idea

And also put some comments

Let me know if it's a good approach

Thanks for time and feedback on this, I really appreciate :)

bchatard avatar Aug 11 '22 06:08 bchatard

Hi, thanks on working on this so quickly :)

I think the approach in Application::getDefaultInputDefinition() is better, because it's closer to the point of origin of this problem. The Kernel is quite abstract place and might be hard to connect the dots.

Could you move it to the Application one?

TomasVotruba avatar Aug 11 '22 07:08 TomasVotruba

I move back to the KernelBootAndApplicationRun with simple implementation (and comment).

bchatard avatar Aug 11 '22 08:08 bchatard

Thank you :clap:

TomasVotruba avatar Aug 11 '22 09:08 TomasVotruba