deployer icon indicating copy to clipboard operation
deployer copied to clipboard

Bump php/symfony dependencies or make it less strict

Open ITspirit opened this issue 1 year ago • 3 comments

Bump Dependencies or make it less strict. Otherwise these tool will be blocked out for further usage.

Currently lot of dependencies are really selective, without need.

    "require": {
        "php": "^8.0|^7.3",
        "symfony/console": "^5.4.9",
        "symfony/process": "^5",
        "symfony/yaml": "^5"
    },

Why not make it less strict?

    "require": {
        "php": ">=7.3",
        "symfony/console": ">=5.4.9",
        "symfony/process": ">=5",
        "symfony/yaml": ">=5"
    },

So i could use it in projects with much modern dependencies.

Any concerns about this?

Upvote & Fund

  • We're using Polar.sh so you can upvote and help fund this issue.
  • We receive the funding once the issue is completed & confirmed by you.
  • Thank you in advance for helping prioritize & fund our backlog.
Fund with Polar

ITspirit avatar Jul 23 '24 09:07 ITspirit

We are running into issues with this as well.

martijn94 avatar Jul 31 '24 08:07 martijn94

Are you using dev-master branch? Please use tagged versions. Those don’t have any deps.

antonmedv avatar Jul 31 '24 11:07 antonmedv

Are you using dev-master branch? Please use tagged versions. Those don’t have any deps.

I know it's a specific use case, but the problem arises for us when we include the project's composer autoloader in our deploy.php to be able to use some custom recipe's we published in our own composer packages.

This also loads a more recent version of symfony/console resulting in the following error for us:

PHP Fatal error: Declaration of Deployer\Component\PharUpdate\Console\Command::execute(Symfony\Component\Console\Input\InputInterface $input, Symfony\Component\Console\Output\OutputInterface $output) must be compatible with Symfony\Component\Console\Command\Command::execute(Symfony\Component\Console\Input\InputInterface $input, Symfony\Component\Console\Output\OutputInterface $output): int

martijn94 avatar Jul 31 '24 11:07 martijn94

This issue has been automatically closed. Please, open a discussion for bug reports and feature requests.

Read more: [https://github.com/deployphp/deployer/discussions/3888]

github-actions[bot] avatar Sep 09 '24 20:09 github-actions[bot]