deployer icon indicating copy to clipboard operation
deployer copied to clipboard

remove() Function to Remove Config Params from Existing Config Array

Open sprankhub opened this issue 3 years ago • 0 comments
trafficstars

Wouldn't it make sense to provide remove(), similar to add()? Usage example:

Core recipe (from the magento2 recipe):

set('shared_dirs', [
    'var/composer_home',
    'var/log',
    'var/export',
    'var/report',
    'var/import',
    'var/import_history',
    'var/session',
    'var/importexport',
    'var/backups',
    'var/tmp',
    'pub/sitemap',
    'pub/media'
]);

Inside my deploy.php:

remove('shared_dirs', 'pub/sitemap');

Resulting config value for shared_dirs:

[
    'var/composer_home',
    'var/log',
    'var/export',
    'var/report',
    'var/import',
    'var/import_history',
    'var/session',
    'var/importexport',
    'var/backups',
    'var/tmp',
    'pub/media'
]

Since there is add, I think it is natural to also have the opposite. Currently, it needs to be done with get and set.

Upvote & Fund

  • We're using Polar.sh so you can upvote and help fund this issue.
  • We receive the funding once the issue is completed & confirmed by you.
  • Thank you in advance for helping prioritize & fund our backlog.
Fund with Polar

sprankhub avatar Oct 20 '22 15:10 sprankhub