deployer icon indicating copy to clipboard operation
deployer copied to clipboard

shared-directory should only be created if needed

Open alexgit2k opened this issue 3 years ago • 0 comments

The task deploy:setup creates the directories .dep, releases and shared if they do not exist: https://github.com/deployphp/deployer/blob/c36566145a8c17fda3feecbc802e6fb9e7edaa59/recipe/deploy/setup.php#L9-L11

If shared_dirs and shared_files are not set the shared is not needed and should therefore be not created.

The task deploy:shared uses -p for --parents for creating directories, which would also create parent directories like the shared-directory: https://github.com/deployphp/deployer/blob/c36566145a8c17fda3feecbc802e6fb9e7edaa59/recipe/deploy/shared.php#L43 So line 11 in recipe/deploy/setup.php is not needed: https://github.com/deployphp/deployer/blob/c36566145a8c17fda3feecbc802e6fb9e7edaa59/recipe/deploy/setup.php#L11

Upvote & Fund

  • We're using Polar.sh so you can upvote and help fund this issue.
  • We receive the funding once the issue is completed & confirmed by you.
  • Thank you in advance for helping prioritize & fund our backlog.
Fund with Polar

alexgit2k avatar Jul 13 '22 09:07 alexgit2k