terraform-provider-jamfpro icon indicating copy to clipboard operation
terraform-provider-jamfpro copied to clipboard

Computer groups bug

Open w0de opened this issue 9 months ago • 0 comments

  • Adds install and build_override rules to makefile.

I've been using these during local dev to make my life easier. The idea is to run make install to quickly update the local build. Rule also outputs the required ~/.terraformrc override config with correct path.

  • Fixes a type error I see when trying to compile main:
internal/endpoints/apiroles/apiroles_resource.go:111:44: cannot use intID (variable of type int) as string value in argument to apiclient.Conn.GetJamfApiRoleByID
make: *** [build] Error 1
  • Updates the computergroup validation function to accept a computers array when isSmart is true but no site is defined.

This matches the logic used when updating state, explicated by this comment. As of now, I can't update to 0.52 because this validation fails solely from reading extant state 🤕.

w0de avatar May 16 '24 01:05 w0de