node-precinct icon indicating copy to clipboard operation
node-precinct copied to clipboard

Published 20 hours ago • verified publisher icon dependents

Mocha strict

Open XhmikosR opened this issue 2 years ago • 3 comments

XhmikosR avatar Mar 03 '22 13:03 XhmikosR

@mrjoelkemp so, it seems there's still one error due to strict mode. Do you have any ideas how to fix this in node-source-walk?

If you manage to fix it, let me know.

EDIT: Wait, this seems to be coming from detective-less, but still would be nice if we could solve this in node-source-walk.

XhmikosR avatar Mar 03 '22 13:03 XhmikosR

@mrjoelkemp any ideas? Should I revert the node-source-walk strict patches?

XhmikosR avatar Mar 08 '22 09:03 XhmikosR

@mrjoelkemp I had a closer look and it seems the issue will be fixed in detective-less if they update to the latest node-source-walk.

I tried to contact the fork owner https://github.com/Mike-Dax/node-detective-less/commit/cb391fde6f17a1befe729615ff36969d908e1096 but if we don't get a reply we should consider picking their patches in our detective-less repo, switching to a scoped package and moving on.

Other than that, I think we are OK with the patches in node-source-walk after all :)

XhmikosR avatar Mar 18 '22 05:03 XhmikosR