dependabot-core icon indicating copy to clipboard operation
dependabot-core copied to clipboard

Published 20 hours ago • verified publisher icon dependabot

Enable RSpec/EmptyExampleGroup

Open robaiken opened this issue 9 months ago • 4 comments

https://docs.rubocop.org/rubocop-rspec/cops_rspec.html#rspecemptyexamplegroup

robaiken avatar May 14 '24 13:05 robaiken

Do we want to keep these tests or are we happy with deleting them?

robaiken avatar May 14 '24 13:05 robaiken

@robaiken could you dig out why they were disabled? As it stands, I'd rather delete them then keep them commented out, but if it's easy to fix them and make them reliable/fast, that seems better?

jurre avatar May 14 '24 13:05 jurre

@jurre I couldn't find the context about why the NuGet tests were skipped. Both tests seemed to have issues related to VCR

robaiken avatar May 14 '24 14:05 robaiken

@jurre I think it's up to the Azure team if they want to keep the tests or not. I have sent them a message, so they are aware of the skipped tests.

robaiken avatar May 15 '24 15:05 robaiken