dependabot-core
dependabot-core copied to clipboard
Added support for .tool-versions file in Gemfile for Ruby projects
This MR is related to https://github.com/dependabot/dependabot-core/issues/1033 in a way that it adds support for .tool-versions
files for Ruby projects.
Starting with Bunder 2.4.20, it supports specifying Ruby version via .tool-versions
(see https://github.com/rubygems/rubygems/pull/6898 and Specifying a Ruby Version). Unfortunately, Dependabot does not download this file and does not parse Ruby version from it.
This MR enables Ruby projects to specify Ruby version in a single file.
Looking forward to this! Thank you @kpumuk
Looking forward to this! Thank you @kpumuk
You and me both :-) I hope this will eventually get attention from maintainers.
@deivid-rodriguez seeing you were involved in adding support for this in rubygems
, can you help move this forward by reviewing or assigning the right person? Dependabot is still broken for us and many others:
Hei, I no longer maintain Dependabot.
This seems tested and ready to be reviewed though, so since it's been hanging for a couple months, I think it's fine to politely ping some other maintainer and ask for a review.
The Dependabot team is usually super keen on taking community contributions, they are just very busy :sweat_smile:.
@robaiken @landongrindheim you guys have done a lot of great work on the Ruby side of things of Dependabot. Would you have a moment to review/merge?
@jurre rebased main and reworded tests to address linter errors in https://github.com/dependabot/dependabot-core/actions/runs/9117390435/job/25068129813
Hi @jurre , Request you to have a quick review and approve as @kpumuk has added new commits after last approval. Thank you.
Thanks everyone!
Omg it's been merged! Thank you all 🥳
Edit: works like a charm
- swissclubto/swissclubto.github.io#288
- swissclubto/swissclubto.github.io#289