dependabot-core icon indicating copy to clipboard operation
dependabot-core copied to clipboard

Added support for .tool-versions file in Gemfile for Ruby projects

Open kpumuk opened this issue 1 year ago • 8 comments

This MR is related to https://github.com/dependabot/dependabot-core/issues/1033 in a way that it adds support for .tool-versions files for Ruby projects.

Starting with Bunder 2.4.20, it supports specifying Ruby version via .tool-versions (see https://github.com/rubygems/rubygems/pull/6898 and Specifying a Ruby Version). Unfortunately, Dependabot does not download this file and does not parse Ruby version from it.

This MR enables Ruby projects to specify Ruby version in a single file.

kpumuk avatar Feb 16 '24 19:02 kpumuk

Looking forward to this! Thank you @kpumuk

janklimo avatar Mar 30 '24 15:03 janklimo

Looking forward to this! Thank you @kpumuk

You and me both :-) I hope this will eventually get attention from maintainers.

kpumuk avatar Mar 31 '24 00:03 kpumuk

@deivid-rodriguez seeing you were involved in adding support for this in rubygems, can you help move this forward by reviewing or assigning the right person? Dependabot is still broken for us and many others:

Screenshot 2024-05-15 at 10 58 42

janklimo avatar May 15 '24 04:05 janklimo

Hei, I no longer maintain Dependabot.

This seems tested and ready to be reviewed though, so since it's been hanging for a couple months, I think it's fine to politely ping some other maintainer and ask for a review.

The Dependabot team is usually super keen on taking community contributions, they are just very busy :sweat_smile:.

deivid-rodriguez avatar May 16 '24 09:05 deivid-rodriguez

@robaiken @landongrindheim you guys have done a lot of great work on the Ruby side of things of Dependabot. Would you have a moment to review/merge?

janklimo avatar May 16 '24 10:05 janklimo

@jurre rebased main and reworded tests to address linter errors in https://github.com/dependabot/dependabot-core/actions/runs/9117390435/job/25068129813

kpumuk avatar May 18 '24 14:05 kpumuk

Hi @jurre , Request you to have a quick review and approve as @kpumuk has added new commits after last approval. Thank you.

sachin-sandhu avatar May 19 '24 23:05 sachin-sandhu

Thanks everyone!

jurre avatar May 21 '24 10:05 jurre

Omg it's been merged! Thank you all 🥳

Edit: works like a charm

  • swissclubto/swissclubto.github.io#288
  • swissclubto/swissclubto.github.io#289

bewuethr avatar May 24 '24 16:05 bewuethr