dependabot-core unknown_error in nuget Dependencies failed to update

Is there an existing issue for this?

[X] I have searched the existing issues

Package ecosystem

nuget

Package manager version

No response

Language version

Dependabot is running natively on our github repo

Manifest location and content before the Dependabot update

"/Invirto/ContentServer/ContentServer.sln"
 "/Invirto/ContentServer/ContentServer/Backend/Core.csproj"
 "/Invirto/ContentServer/ContentServer/Backend/otherSubprojectsDependingOnCore/otherSubprojectsDependingOnCore.csproj"

dependabot.yml content

version: 2 updates:

package-ecosystem: "nuget" directory: "/Invirto/ContentServer" open-pull-requests-limit: 25 schedule: interval: "monthly" groups: content-server-nuget-dependencies: # name of the group update-types: # group all updates for minor and patch versions into a single PR, major changes will be created as individual PRs - "minor" - "patch"

Updated dependency

What you expected to see, versus what you actually saw

We got a nested multi project setup. We got dependabot pointing to the sln file: ContentServer/ContentServer.sln

In that directory we got a Core project where most of the general dependencies are installed.

ContentServer/Backend/Core/Core.csproj

We got services in the same sln file that got the Core project as dependency.

E.g. Contentserver/Backend/Service1/Servicee1.csproj <-- has the Core project as dependency.

if there is a dependency to be updated in the service itself (not installed in core) the pr is correctly created.

If there is a dependency that needs updating in Core, it fails to create the PR.

e.g. Microsoft.NET.Sdk.Functions is installed in a service and it updates fine.

Polly is installed in Core and fails to update. I can see these errors in the log:

updater |   No dotnet-tools.json files found.
updater | Running for project [/home/dependabot/dependabot-updater/repo/Invirto/ContentServer/Web/Admin.Test/Admin.Test.csproj]
updater |   Updating [Invirto/ContentServer/global.json] file.
updater |     Dependency [Polly] not found.
updater |   Running for SDK-style project
updater |     Package [Polly] Does not exist as a dependency in [/home/dependabot/dependabot-updater/repo/Invirto/ContentServer/Web/Admin.Test/Admin.Test.csproj].
updater | Update complete.
updater | 2024/02/05 16:26:46 INFO <job_783022848> [Transport] Sending envelope with items [event] e25c79f421a14ee9baa16ac78bf8bc63 to Sentry
  proxy | 2024/02/05 16:26:46 [862] POST https://sentry.io:443/api/1451818/envelope/
  proxy | 2024/02/05 16:26:46 [862] 200 https://sentry.io:443/api/1451818/envelope/
updater | 2024/02/05 16:26:46 ERROR <job_783022848> Error processing Polly (Dependabot::DependabotError)
updater | 2024/02/05 16:26:46 ERROR <job_783022848> FileUpdater failed
updater | 2024/02/05 16:26:46 ERROR <job_783022848> /home/dependabot/dependabot-updater/lib/dependabot/dependency_change_builder.rb:43:in `run'
updater | 2024/02/05 16:26:46 ERROR <job_783022848> /home/dependabot/dependabot-updater/lib/dependabot/dependency_change_builder.rb:26:in `create_from'
updater | 2024/02/05 16:26:46 ERROR <job_783022848> /home/dependabot/dependabot-updater/lib/dependabot/updater/group_update_creation.rb:95:in `create_change_for'
updater | 2024/02/05 16:26:46 ERROR <job_783022848> /home/dependabot/dependabot-updater/lib/dependabot/updater/group_update_creation.rb:56:in `block in compile_all_dependency_changes_for'
updater | 2024/02/05 16:26:46 ERROR <job_783022848> /home/dependabot/dependabot-updater/lib/dependabot/updater/group_update_creation.rb:29:in `each'
updater | 2024/02/05 16:26:46 ERROR <job_783022848> /home/dependabot/dependabot-updater/lib/dependabot/updater/group_update_creation.rb:29:in `compile_all_dependency_changes_for'
updater | 2024/02/05 16:26:46 ERROR <job_783022848> /home/dependabot/dependabot-updater/lib/dependabot/updater/operations/create_group_update_pull_request.rb:70:in `dependency_change'
updater | 2024/02/05 16:26:46 ERROR <job_783022848> /home/dependabot/dependabot-updater/lib/dependabot/updater/operations/create_group_update_pull_request.rb:44:in `perform'
updater | 2024/02/05 16:26:46 ERROR <job_783022848> /home/dependabot/dependabot-updater/lib/dependabot/updater/operations/group_update_all_versions.rb:119:in `run_update_for'
updater | 2024/02/05 16:26:46 ERROR <job_783022848> /home/dependabot/dependabot-updater/lib/dependabot/updater/operations/group_update_all_versions.rb:101:in `block in run_grouped_dependency_updates'
updater | 2024/02/05 16:26:46 ERROR <job_783022848> /home/dependabot/dependabot-updater/lib/dependabot/updater/operations/group_update_all_versions.rb:100:in `each'
updater | 2024/02/05 16:26:46 ERROR <job_783022848> /home/dependabot/dependabot-updater/lib/dependabot/updater/operations/group_update_all_versions.rb:100:in `run_grouped_dependency_updates'
updater | 2024/02/05 16:26:46 ERROR <job_783022848> /home/dependabot/dependabot-updater/lib/dependabot/updater/operations/group_update_all_versions.rb:47:in `perform'
updater | 2024/02/05 16:26:46 ERROR <job_783022848> /home/dependabot/dependabot-updater/lib/dependabot/updater.rb:45:in `run'
updater | 2024/02/05 16:26:46 ERROR <job_783022848> /home/dependabot/dependabot-updater/lib/dependabot/update_files_command.rb:43:in `perform_job'
updater | 2024/02/05 16:26:46 ERROR <job_783022848> /home/dependabot/dependabot-updater/lib/dependabot/base_command.rb:36:in `run'
updater | 2024/02/05 16:26:46 ERROR <job_783022848> bin/update_files.rb:24:in `<main>'

Or this one:

updater |   No dotnet-tools.json files found.
updater | Running for project [/home/dependabot/dependabot-updater/repo/Invirto/ContentServer/Web/Admin.Test/Admin.Test.csproj]
updater |   Updating [Invirto/ContentServer/global.json] file.
updater |     Dependency [Microsoft.IdentityModel.Protocols.OpenIdConnect] not found.
updater |   Running for SDK-style project
updater |     Package [Microsoft.IdentityModel.Protocols.OpenIdConnect] Does not exist as a dependency in [/home/dependabot/dependabot-updater/repo/Invirto/ContentServer/Web/Admin.Test/Admin.Test.csproj].
updater | Update complete.
updater | 2024/02/05 16:22:25 INFO <job_783022848> [Transport] Sending envelope with items [event] 4495ba163be34a3580939c9f7a51ce7e to Sentry
  proxy | 2024/02/05 16:22:25 [575] POST https://sentry.io:443/api/1451818/envelope/
  proxy | 2024/02/05 16:22:25 [575] 200 https://sentry.io:443/api/1451818/envelope/
updater | 2024/02/05 16:22:25 ERROR <job_783022848> Error processing Microsoft.IdentityModel.Protocols.OpenIdConnect (Dependabot::DependabotError)
updater | 2024/02/05 16:22:25 ERROR <job_783022848> FileUpdater failed
updater | 2024/02/05 16:22:25 ERROR <job_783022848> /home/dependabot/dependabot-updater/lib/dependabot/dependency_change_builder.rb:43:in `run'
updater | 2024/02/05 16:22:25 ERROR <job_783022848> /home/dependabot/dependabot-updater/lib/dependabot/dependency_change_builder.rb:26:in `create_from'
updater | 2024/02/05 16:22:25 ERROR <job_783022848> /home/dependabot/dependabot-updater/lib/dependabot/updater/group_update_creation.rb:95:in `create_change_for'
updater | 2024/02/05 16:22:25 ERROR <job_783022848> /home/dependabot/dependabot-updater/lib/dependabot/updater/group_update_creation.rb:56:in `block in compile_all_dependency_changes_for'
updater | 2024/02/05 16:22:25 ERROR <job_783022848> /home/dependabot/dependabot-updater/lib/dependabot/updater/group_update_creation.rb:29:in `each'
updater | 2024/02/05 16:22:25 ERROR <job_783022848> /home/dependabot/dependabot-updater/lib/dependabot/updater/group_update_creation.rb:29:in `compile_all_dependency_changes_for'
updater | 2024/02/05 16:22:25 ERROR <job_783022848> /home/dependabot/dependabot-updater/lib/dependabot/updater/operations/create_group_update_pull_request.rb:70:in `dependency_change'
updater | 2024/02/05 16:22:25 ERROR <job_783022848> /home/dependabot/dependabot-updater/lib/dependabot/updater/operations/create_group_update_pull_request.rb:44:in `perform'
updater | 2024/02/05 16:22:25 ERROR <job_783022848> /home/dependabot/dependabot-updater/lib/dependabot/updater/operations/group_update_all_versions.rb:119:in `run_update_for'
updater | 2024/02/05 16:22:25 ERROR <job_783022848> /home/dependabot/dependabot-updater/lib/dependabot/updater/operations/group_update_all_versions.rb:101:in `block in run_grouped_dependency_updates'
updater | 2024/02/05 16:22:25 ERROR <job_783022848> /home/dependabot/dependabot-updater/lib/dependabot/updater/operations/group_update_all_versions.rb:100:in `each'
updater | 2024/02/05 16:22:25 ERROR <job_783022848> /home/dependabot/dependabot-updater/lib/dependabot/updater/operations/group_update_all_versions.rb:100:in `run_grouped_dependency_updates'
updater | 2024/02/05 16:22:25 ERROR <job_783022848> /home/dependabot/dependabot-updater/lib/dependabot/updater/operations/group_update_all_versions.rb:47:in `perform'
updater | 2024/02/05 16:22:25 ERROR <job_783022848> /home/dependabot/dependabot-updater/lib/dependabot/updater.rb:45:in `run'
updater | 2024/02/05 16:22:25 ERROR <job_783022848> /home/dependabot/dependabot-updater/lib/dependabot/update_files_command.rb:43:in `perform_job'
updater | 2024/02/05 16:22:25 ERROR <job_783022848> /home/dependabot/dependabot-updater/lib/dependabot/base_command.rb:36:in `run'
updater | 2024/02/05 16:22:25 ERROR <job_783022848> bin/update_files.rb:24:in `<main>'

global.json:

{
    "sdk": {
      "version": "8.0.101",
      "rollForward": "latestFeature"
    }
}

Native package manager behavior

When using the native package manager command, it reports the outdated packages as usual

Images of the diff or a link to the PR, issue, or logs

No response

Smallest manifest that reproduces the issue

No response

If there is anythig more you need, let me know

Feb 06 '24 09:02 johnsympatient

Some additional info that might help: For the moment we switched back to adding each .csproj file to the dependabot config.

It produces this PR for one of our services:

Bumps the monitoring-nuget-dependencies group in /Invirto/ContentServer/Backend/MonitoringInvirto with 3 updates: [Microsoft.NET.Sdk.Functions](https://github.com/Azure/azure-functions-vs-build-sdk), [Microsoft.IdentityModel.Protocols.OpenIdConnect](https://github.com/AzureAD/azure-activedirectory-identitymodel-extensions-for-dotnet) and [Polly](https://github.com/App-vNext/Polly).

Updates Microsoft.NET.Sdk.Functions from 4.2.0 to 4.3.0

Release notes
Commits

Updates Microsoft.IdentityModel.Protocols.OpenIdConnect from 7.2.0 to 7.3.1

Release notes
Changelog
Commits

Updates Polly from 8.2.1 to 8.3.0

Release notes
Changelog
Commits

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.

But in the changeset, only Polly, that is installed in the Core project is updated to 8.3.0. OpenIdConnect and SDKFunctions is not included in the Core, but in the individual service and is not updated

Feb 06 '24 14:02 johnsympatient

I can reproduce same[^1]? issue. See Readme in a small repository. IMHO, NuGet updater must iterate all projects and update each for the changed reference. It seems that it stops iterating after the 1st. And when that project does not refer to the NuGet package, no files are changed. Dependabot detects no changed files and throws 'FileUpdater failed'.

[^1]: @johnsympatient Can you confirm that it is indeed the same issue?

Feb 08 '24 17:02 leonvandermeer

@leonvandermeer Thanks for creating the reproduction repo. I can confirm that this is the exact issue I am getting

Feb 09 '24 13:02 johnsympatient

Any known workaround for this? I'm getting it in a lot of repositories on Test projects. Also can't understand why some repositories with similar patterns do not fail.

My csproj files look like this (just some file and package names changed so I can post them):

MainProject:

<Project Sdk="Microsoft.NET.Sdk">

  <PropertyGroup>
        <Configuration Condition=" '$(Configuration)' == '' ">Debug</Configuration>
        <Platform Condition=" '$(Platform)' == '' ">AnyCPU</Platform>
        <TreatWarningsAsErrors>true</TreatWarningsAsErrors>
    </PropertyGroup>

    <PropertyGroup>
        <TargetFramework>netstandard2.0</TargetFramework>
    </PropertyGroup>

    <PropertyGroup Condition="'$(Configuration)|$(Platform)'=='Debug|AnyCPU'">
        <DefineConstants>DEBUG;TRACE</DefineConstants>
    </PropertyGroup>

    <ItemGroup>
      <PackageReference Include="Microsoft.SourceLink.GitHub" Version="8.0.0" PrivateAssets="All" />
      <PackageReference Include="GitVersion.MsBuild" Version="5.12.0">
        <PrivateAssets>all</PrivateAssets>
        <IncludeAssets>runtime; build; native; contentfiles; analyzers; buildtransitive</IncludeAssets>
      </PackageReference>
    </ItemGroup>

    <ItemGroup>
        <PackageReference Include="SomePackageName" Version="11.24.0" />
    </ItemGroup>

</Project>

Test Project:

<Project Sdk="Microsoft.NET.Sdk">

  <PropertyGroup>
    <TargetFrameworks>net6;net461</TargetFrameworks>
    <IsTestProject>true</IsTestProject>
    <CopyLocalLockFileAssemblies>true</CopyLocalLockFileAssemblies>
    <PublishRepositoryUrl>true</PublishRepositoryUrl>
  </PropertyGroup>

  <ItemGroup>
    <!-- Package References -->
    <PackageReference Include="coverlet.msbuild" Version="6.0.0">
      <PrivateAssets>all</PrivateAssets>
      <IncludeAssets>runtime; build; native; contentfiles; analyzers; buildtransitive</IncludeAssets>
    </PackageReference>

    <PackageReference Include="GitVersion.MsBuild" Version="5.12.0">
      <PrivateAssets>all</PrivateAssets>
      <IncludeAssets>runtime; build; native; contentfiles; analyzers; buildtransitive</IncludeAssets>
    </PackageReference>

    <PackageReference Include="nunit" Version="3.14.0" />
    <PackageReference Include="Microsoft.NET.Test.Sdk" Version="17.9.0" />
    <PackageReference Include="NUnit3TestAdapter" Version="4.5.0">
      <PrivateAssets>all</PrivateAssets>
      <IncludeAssets>runtime; build; native; contentfiles; analyzers; buildtransitive</IncludeAssets>
    </PackageReference>
  </ItemGroup>

  <ItemGroup>
    <ProjectReference Include="..\..\..\src\MainProject\MainProject.csproj" />
  </ItemGroup>

</Project>

And the error:

updater |   No dotnet-tools.json files found.
updater | Running for project [/home/dependabot/dependabot-updater/repo/tests/UnitTests/MainProject.Tests/MainProject.Tests.csproj]
updater |   Running for SDK-style project
updater |     Package [SomePackageName] Does not exist as a dependency in [/home/dependabot/dependabot-updater/repo/tests/UnitTests/MainProject.Tests/MainProject.Tests.csproj].
updater | Update complete.
updater | 2024/02/19 14:49:52 INFO <job_788842746> [Transport] Sending envelope with items [event] f1d6bcd3af3c40809ec7b89c008cf409 to Sentry
updater | 2024/02/19 14:49:52 ERROR <job_788842746> Error processing SomePackageName (Dependabot::DependabotError)
updater | 2024/02/19 14:49:52 ERROR <job_788842746> FileUpdater failed
updater | 2024/02/19 14:49:52 ERROR <job_788842746> /home/dependabot/dependabot-updater/lib/dependabot/dependency_change_builder.rb:69:in `run'
updater | 2024/02/19 14:49:52 ERROR <job_788842746> /home/dependabot/dependabot-updater/vendor/ruby/3.1.0/gems/sorbet-runtime-0.5.11193/lib/types/private/methods/call_validation.rb:272:in `bind_call'
updater | 2024/02/19 14:49:52 ERROR <job_788842746> /home/dependabot/dependabot-updater/vendor/ruby/3.1.0/gems/sorbet-runtime-0.5.11193/lib/types/private/methods/call_validation.rb:272:in `validate_call'
updater | 2024/02/19 14:49:52 ERROR <job_788842746> /home/dependabot/dependabot-updater/vendor/ruby/3.1.0/gems/sorbet-runtime-0.5.11193/lib/types/private/methods/_methods.rb:272:in `block in _on_method_added'
updater | 2024/02/19 14:49:52 ERROR <job_788842746> /home/dependabot/dependabot-updater/lib/dependabot/dependency_change_builder.rb:42:in `create_from'
updater | 2024/02/19 14:49:52 ERROR <job_788842746> /home/dependabot/dependabot-updater/vendor/ruby/3.1.0/gems/sorbet-runtime-0.5.11193/lib/types/private/methods/call_validation.rb:272:in `bind_call'
updater | 2024/02/19 14:49:52 ERROR <job_788842746> /home/dependabot/dependabot-updater/vendor/ruby/3.1.0/gems/sorbet-runtime-0.5.11193/lib/types/private/methods/call_validation.rb:272:in `validate_call'
updater | 2024/02/19 14:49:52 ERROR <job_788842746> /home/dependabot/dependabot-updater/vendor/ruby/3.1.0/gems/sorbet-runtime-0.5.11193/lib/types/private/methods/_methods.rb:272:in `block in _on_method_added'
updater | 2024/02/19 14:49:52 ERROR <job_788842746> /home/dependabot/dependabot-updater/lib/dependabot/updater/group_update_creation.rb:114:in `create_change_for'
updater | 2024/02/19 14:49:52 ERROR <job_788842746> /home/dependabot/dependabot-updater/lib/dependabot/updater/group_update_creation.rb:72:in `block in compile_all_dependency_changes_for'
updater | 2024/02/19 14:49:52 ERROR <job_788842746> /home/dependabot/dependabot-updater/lib/dependabot/updater/group_update_creation.rb:38:in `each'
updater | 2024/02/19 14:49:52 ERROR <job_788842746> /home/dependabot/dependabot-updater/lib/dependabot/updater/group_update_creation.rb:38:in `compile_all_dependency_changes_for'
updater | 2024/02/19 14:49:52 ERROR <job_788842746> /home/dependabot/dependabot-updater/lib/dependabot/updater/operations/create_group_update_pull_request.rb:70:in `dependency_change'
updater | 2024/02/19 14:49:52 ERROR <job_788842746> /home/dependabot/dependabot-updater/lib/dependabot/updater/operations/create_group_update_pull_request.rb:44:in `perform'
updater | 2024/02/19 14:49:52 ERROR <job_788842746> /home/dependabot/dependabot-updater/lib/dependabot/updater/operations/group_update_all_versions.rb:119:in `run_update_for'
updater | 2024/02/19 14:49:52 ERROR <job_788842746> /home/dependabot/dependabot-updater/lib/dependabot/updater/operations/group_update_all_versions.rb:101:in `block in run_grouped_dependency_updates'
updater | 2024/02/19 14:49:52 ERROR <job_788842746> /home/dependabot/dependabot-updater/lib/dependabot/updater/operations/group_update_all_versions.rb:100:in `each'
updater | 2024/02/19 14:49:52 ERROR <job_788842746> /home/dependabot/dependabot-updater/lib/dependabot/updater/operations/group_update_all_versions.rb:100:in `run_grouped_dependency_updates'
updater | 2024/02/19 14:49:52 ERROR <job_788842746> /home/dependabot/dependabot-updater/lib/dependabot/updater/operations/group_update_all_versions.rb:47:in `perform'
updater | 2024/02/19 14:49:52 ERROR <job_788842746> /home/dependabot/dependabot-updater/lib/dependabot/updater.rb:45:in `run'
updater | 2024/02/19 14:49:52 ERROR <job_788842746> /home/dependabot/dependabot-updater/lib/dependabot/update_files_command.rb:43:in `perform_job'
updater | 2024/02/19 14:49:52 ERROR <job_788842746> /home/dependabot/dependabot-updater/lib/dependabot/base_command.rb:36:in `run'
updater | 2024/02/19 14:49:52 ERROR <job_788842746> bin/update_files.rb:24:in `<main>'

Feb 20 '24 11:02 joaorosado

@JoeRobich @johnsympatient It looks like this issue is solved. Dependabot just worked on my reproducing repository:

Job started at	Job id	Dependabot Core Version [^1]	Job Result
2024/02/22 23:36:01	791091783	v0.244.0	unknown_error
2024/02/23 23:13:29	791548322	v0.245.0	PR to update Octokit (from 9.1.1 to 10.0.0)

I compared the releases, browsed a bit an then concluded that this most probably is the fix.

[^1]: At job's start time, this was the most recent release.

Feb 24 '24 12:02 leonvandermeer

@leonvandermeer @JoeRobich Hello thanks for notifying us. We tried it again and it al least doesnt error out/stop from completing anymore. In your exact case it works. But not in all cases.

We got this:

Core Project --> Admin.Test project and Other.Test project (Both test projects do have Core as Project Reference)

Nunit is included in both Test projects. coverlet.collector only in Admin.Test

I got an PR that suggests to update both, NUnit and coverlet.collector. (Group update)

But in the commit only coverlet.collector is updated.

But it should also be Nunit in both Test projects. All test projects in the log should have been updated, but only the one with the

Result of the check

updater |   No dotnet-tools.json files found.
updater | Running for project file [IContentServer/Web/Admin.Test/Admin.Test.csproj]
updater | Updating project [/home/dependabot/dependabot-/ContentServer/Web/Admin/Admin.csproj]
updater |   Updating [ContentServer/global.json] file.
updater |     Dependency [NUnit] not found.
updater |   Running for SDK-style project
updater |     Package [NUnit] Does not exist as a dependency in [/home/dependabot/dependabot-updater/repo/ContentServer/Web/Admin/Admin.csproj].
updater | Update complete.
updater | Updating project [/home/dependabot/dependabot-updater/repo/ContentServer/Web/Core/Core.csproj]
updater |   Running for SDK-style project
updater |     Package [NUnit] Does not exist as a dependency in [/home/dependabot/dependabot-updater/repo/ContentServer/Web/Core/Core.csproj].
updater | Update complete.
updater | Updating project [/home/dependabot/dependabot-updater/repo/ContentServer/Web/Admin.Test/Admin.Test.csproj]
updater |   Running for SDK-style project
updater |     Found incorrect [PackageReference] version attribute in [ContentServer/Web/Admin.Test/Admin.Test.csproj].
updater |     Saved ContentServer/Web/Admin.Test/Admin.Test.csproj].
updater | Update complete.
updater | Adding BOM to [Tests/Shared.Test/Shared.Test.csproj].
updater | The contents of file [Tests/Shared.Test/Shared.Test.csproj] were updated.
updater | Adding BOM to [Tests/TestUtils/TestUtils.csproj].
updater | The contents of file [Tests/TestUtils/TestUtils.csproj] were updated.
updater | The contents of file [Web/Privacy.Test/Privacy.Test.csproj] were updated.
updater | The contents of file [Web/Admin.Test/Admin.Test.csproj] were updated.
updater | The contents of file [Web/Core.Test/Core.Test.csproj] were updated.

updater | +-------------------------------------------------------------------------------------+
updater | |                         Changes to Dependabot Pull Requests                         |
updater | +---------+---------------------------------------------------------------------------+
updater | | created | NUnit ( from 4.0.1 to 4.1.0 ), coverlet.collector ( from 6.0.0 to 6.0.1 ) |
updater | +---------+---------------------------------------------------------------------------+
updater | time="2024-02-26T19:22:01Z" level=info msg="task complete" container_id=job-792360911-updater exit_code=0 job_id=792360911 step=updater

Feb 27 '24 11:02 johnsympatient