dependabot-core icon indicating copy to clipboard operation
dependabot-core copied to clipboard

`cargo` updater fails with `Error processing url (RuntimeError)`

Open OmarTawfik opened this issue 2 years ago • 3 comments

Is there an existing issue for this?

  • [X] I have searched the existing issues

Package ecosystem

cargo

Package manager version

No response

Language version

No response

Manifest location and content before the Dependabot update

https://github.com/NomicFoundation/slang/blob/main/Cargo.toml

dependabot.yml content

https://github.com/NomicFoundation/slang/blob/main/.github/dependabot.yml

Updated dependency

I suspect it is url, judging from the update logs below.

What you expected to see, versus what you actually saw

I expected the manifest file to be updated, and a new PR to be created, but the job failed with the above error.

Native package manager behavior

No response

Images of the diff or a link to the PR, issue, or logs

https://github.com/NomicFoundation/slang/network/updates/782705697

updater | 2024/02/05 07:16:19 INFO <job_782705697> [Transport] Sending envelope with items [event] 68f354f9207e4db88dd1cd046fb350b4 to Sentry
updater | 2024/02/05 07:16:19 ERROR <job_782705697> Error processing url (RuntimeError)
updater | 2024/02/05 07:16:19 ERROR <job_782705697> Failed to update url!
updater | 2024/02/05 07:16:19 ERROR <job_782705697> /home/dependabot/cargo/lib/dependabot/cargo/file_updater/lockfile_updater.rb:44:in `block in updated_lockfile_content'

Which looks like it is raised here:

https://github.com/dependabot/dependabot-core/blob/2cf924bbff7989f3e3251815c6df5a6c0a408782/cargo/lib/dependabot/cargo/file_updater/lockfile_updater.rb#L44

Smallest manifest that reproduces the issue

No response

OmarTawfik avatar Feb 05 '24 22:02 OmarTawfik

Another repro here:

https://github.com/NomicFoundation/slang/network/updates/791916698

updater | 2024/02/26 07:18:43 ERROR <job_791916698> Error processing url (RuntimeError)
updater | 2024/02/26 07:18:43 ERROR <job_791916698> Failed to update url!
updater | 2024/02/26 07:18:43 ERROR <job_791916698> /home/dependabot/cargo/lib/dependabot/cargo/file_updater/lockfile_updater.rb:44:in `block in updated_lockfile_content'
updater | 2024/02/26 07:18:43 ERROR <job_791916698> /home/dependabot/common/lib/dependabot/shared_helpers.rb:81:in `block in in_a_temporary_directory'
updater | 2024/02/26 07:18:43 ERROR <job_791916698> /home/dependabot/common/lib/dependabot/shared_helpers.rb:81:in `chdir'
updater | 2024/02/26 07:18:43 ERROR <job_791916698> /home/dependabot/common/lib/dependabot/shared_helpers.rb:81:in `in_a_temporary_directory'
updater | 2024/02/26 07:18:43 ERROR <job_791916698> /home/dependabot/dependabot-updater/vendor/ruby/3.1.0/gems/sorbet-runtime-0.5.11193/lib/types/private/methods/call_validation.rb:272:in `bind_call'
updater | 2024/02/26 07:18:43 ERROR <job_791916698> /home/dependabot/dependabot-updater/vendor/ruby/3.1.0/gems/sorbet-runtime-0.5.11193/lib/types/private/methods/call_validation.rb:272:in `validate_call'
updater | 2024/02/26 07:18:43 ERROR <job_791916698> /home/dependabot/dependabot-updater/vendor/ruby/3.1.0/gems/sorbet-runtime-0.5.11193/lib/types/private/methods/call_validation.rb:193:in `block in create_validator_slow'
updater | 2024/02/26 07:18:43 ERROR <job_791916698> /home/dependabot/cargo/lib/dependabot/cargo/file_updater/lockfile_updater.rb:30:in `updated_lockfile_content'
updater | 2024/02/26 07:18:43 ERROR <job_791916698> /home/dependabot/cargo/lib/dependabot/cargo/file_updater.rb:67:in `updated_lockfile_content'
updater | 2024/02/26 07:18:43 ERROR <job_791916698> /home/dependabot/cargo/lib/dependabot/cargo/file_updater.rb:38:in `updated_dependency_files'
updater | 2024/02/26 07:18:43 ERROR <job_791916698> /home/dependabot/dependabot-updater/lib/dependabot/dependency_change_builder.rb:135:in `generate_dependency_files'
updater | 2024/02/26 07:18:43 ERROR <job_791916698> /home/dependabot/dependabot-updater/vendor/ruby/3.1.0/gems/sorbet-runtime-0.5.11193/lib/types/private/methods/call_validation.rb:272:in `bind_call'
updater | 2024/02/26 07:18:43 ERROR <job_791916698> /home/dependabot/dependabot-updater/vendor/ruby/3.1.0/gems/sorbet-runtime-0.5.11193/lib/types/private/methods/call_validation.rb:272:in `validate_call'
updater | 2024/02/26 07:18:43 ERROR <job_791916698> /home/dependabot/dependabot-updater/vendor/ruby/3.1.0/gems/sorbet-runtime-0.5.11193/lib/types/private/methods/_methods.rb:272:in `block in _on_method_added'
updater | 2024/02/26 07:18:43 ERROR <job_791916698> /home/dependabot/dependabot-updater/lib/dependabot/dependency_change_builder.rb:68:in `run'
updater | 2024/02/26 07:18:43 ERROR <job_791916698> /home/dependabot/dependabot-updater/vendor/ruby/3.1.0/gems/sorbet-runtime-0.5.11193/lib/types/private/methods/call_validation.rb:272:in `bind_call'
updater | 2024/02/26 07:18:43 ERROR <job_791916698> /home/dependabot/dependabot-updater/vendor/ruby/3.1.0/gems/sorbet-runtime-0.5.11193/lib/types/private/methods/call_validation.rb:272:in `validate_call'
updater | 2024/02/26 07:18:43 ERROR <job_791916698> /home/dependabot/dependabot-updater/vendor/ruby/3.1.0/gems/sorbet-runtime-0.5.11193/lib/types/private/methods/_methods.rb:272:in `block in _on_method_added'
updater | 2024/02/26 07:18:43 ERROR <job_791916698> /home/dependabot/dependabot-updater/lib/dependabot/dependency_change_builder.rb:42:in `create_from'
updater | 2024/02/26 07:18:43 ERROR <job_791916698> /home/dependabot/dependabot-updater/vendor/ruby/3.1.0/gems/sorbet-runtime-0.5.11193/lib/types/private/methods/call_validation.rb:272:in `bind_call'
updater | 2024/02/26 07:18:43 ERROR <job_791916698> /home/dependabot/dependabot-updater/vendor/ruby/3.1.0/gems/sorbet-runtime-0.5.11193/lib/types/private/methods/call_validation.rb:272:in `validate_call'
updater | 2024/02/26 07:18:43 ERROR <job_791916698> /home/dependabot/dependabot-updater/vendor/ruby/3.1.0/gems/sorbet-runtime-0.5.11193/lib/types/private/methods/_methods.rb:272:in `block in _on_method_added'
updater | 2024/02/26 07:18:43 ERROR <job_791916698> /home/dependabot/dependabot-updater/lib/dependabot/updater/group_update_creation.rb:114:in `create_change_for'
updater | 2024/02/26 07:18:43 ERROR <job_791916698> /home/dependabot/dependabot-updater/lib/dependabot/updater/group_update_creation.rb:72:in `block in compile_all_dependency_changes_for'
updater | 2024/02/26 07:18:43 ERROR <job_791916698> /home/dependabot/dependabot-updater/lib/dependabot/updater/group_update_creation.rb:38:in `each'
updater | 2024/02/26 07:18:43 ERROR <job_791916698> /home/dependabot/dependabot-updater/lib/dependabot/updater/group_update_creation.rb:38:in `compile_all_dependency_changes_for'
updater | 2024/02/26 07:18:43 ERROR <job_791916698> /home/dependabot/dependabot-updater/lib/dependabot/updater/operations/create_group_update_pull_request.rb:70:in `dependency_change'
updater | 2024/02/26 07:18:43 ERROR <job_791916698> /home/dependabot/dependabot-updater/lib/dependabot/updater/operations/create_group_update_pull_request.rb:44:in `perform'
updater | 2024/02/26 07:18:43 ERROR <job_791916698> /home/dependabot/dependabot-updater/lib/dependabot/updater/operations/group_update_all_versions.rb:125:in `run_update_for'
updater | 2024/02/26 07:18:43 ERROR <job_791916698> /home/dependabot/dependabot-updater/lib/dependabot/updater/operations/group_update_all_versions.rb:107:in `block in run_grouped_dependency_updates'
updater | 2024/02/26 07:18:43 ERROR <job_791916698> /home/dependabot/dependabot-updater/lib/dependabot/updater/operations/group_update_all_versions.rb:106:in `each'
updater | 2024/02/26 07:18:43 ERROR <job_791916698> /home/dependabot/dependabot-updater/lib/dependabot/updater/operations/group_update_all_versions.rb:106:in `run_grouped_dependency_updates'
updater | 2024/02/26 07:18:43 ERROR <job_791916698> /home/dependabot/dependabot-updater/lib/dependabot/updater/operations/group_update_all_versions.rb:53:in `perform'
updater | 2024/02/26 07:18:43 ERROR <job_791916698> /home/dependabot/dependabot-updater/lib/dependabot/updater.rb:45:in `run'

OmarTawfik avatar Feb 26 '24 08:02 OmarTawfik

cc @jakecoffman

OmarTawfik avatar Feb 26 '24 08:02 OmarTawfik

@thavaahariharangit this is the other issue I mentioned, which is still happening today. The url crate is one of the most popular Rust crates, with roughly 350,000 daily installs:

https://crates.io/crates/url

OmarTawfik avatar May 15 '24 01:05 OmarTawfik