dependabot-core icon indicating copy to clipboard operation
dependabot-core copied to clipboard

Add extra tests to test if the nuget version implementation is correct

Open amazimbe opened this issue 1 year ago • 1 comments

What are you trying to accomplish?

Add extra tests to test if the current nuget version implementation, in ruby, is correct.

Nuget have a version identifier spec and I'm trying to confirm if our current version implementation abides by this specification.

Checklist

  • [ ] I have run the complete test suite to ensure all tests and linters pass.
  • [ ] I have thoroughly tested my code changes to ensure they work as expected, including adding additional tests for new functionality.
  • [ ] I have written clear and descriptive commit messages.
  • [ ] I have provided a detailed description of the changes in the pull request, including the problem it addresses, how it fixes the problem, and any relevant details about the implementation.
  • [ ] I have ensured that the code is well-documented and easy to understand.

amazimbe avatar Oct 17 '24 11:10 amazimbe

@brettfo I was just testing the current version.rb in nuget and some of the ruby tests I added are failing so I know it does not abide by the nuget version spec.

I'm also aware of the C# version implementation here but I'm not entirely sure if we're using the ruby version or the C# version, or indeed, how the two work together. Could you please clarify.

From what I've understood so far, I do not need to update the ruby version implementation to match the nuget version specification as that is already being done in the C# implementation.

amazimbe avatar Oct 17 '24 11:10 amazimbe