dependabot-core icon indicating copy to clipboard operation
dependabot-core copied to clipboard

Remove python_new_version feature flag and irrelevant code

Open amazimbe opened this issue 1 year ago • 2 comments

What are you trying to accomplish?

Remove a feature flag and code that is no longer needed.

The feature flag was added in this PR to ensure the new python version changes could be turned off easily if necessary.

It also removes old code from the previous implementation that is no longer relevant e.g the old version regex.

Anything you want to highlight for special attention from reviewers?

Checklist

  • [x] I have run the complete test suite to ensure all tests and linters pass.
  • [x] I have thoroughly tested my code changes to ensure they work as expected, including adding additional tests for new functionality.
  • [x] I have written clear and descriptive commit messages.
  • [x] I have provided a detailed description of the changes in the pull request, including the problem it addresses, how it fixes the problem, and any relevant details about the implementation.
  • [x] I have ensured that the code is well-documented and easy to understand.

amazimbe avatar Oct 16 '24 08:10 amazimbe

Seems this is removing both the feature flag and (some of) the old version code?

jurre avatar Oct 16 '24 09:10 jurre

Seems this is removing both the feature flag and (some of) the old version code?

Yes, it also removes the old versioning code that's no longer applicable in the new version. It replaces the old regex with the new one, for example.

amazimbe avatar Oct 16 '24 10:10 amazimbe