dependabot-core icon indicating copy to clipboard operation
dependabot-core copied to clipboard

Strict type `go_modules`

Open JamieMagee opened this issue 1 year ago • 0 comments

What are you trying to accomplish?

Complete strict sorbet typing go_modules

Anything you want to highlight for special attention from reviewers?

Also enabled Sorbet/StrictSigil to prevent regressions

How will you know you've accomplished your goal?

Tests pass

Checklist

  • [x] I have run the complete test suite to ensure all tests and linters pass.
  • [x] I have thoroughly tested my code changes to ensure they work as expected, including adding additional tests for new functionality.
  • [x] I have written clear and descriptive commit messages.
  • [x] I have provided a detailed description of the changes in the pull request, including the problem it addresses, how it fixes the problem, and any relevant details about the implementation.
  • [x] I have ensured that the code is well-documented and easy to understand.

JamieMagee avatar Jun 29 '24 04:06 JamieMagee

Hi @schani, I saw an earlier post from you from 2017 ([https://github.com/glideapps/quicktype/issues/165])

It mentions RapidJson and nholmann/json. However, I see quicktype only supports nholmann/json (C++), by default. Is there a plan to support RapidJson (C++) as well? I think RapidJson is more preferred for resource constrained embedded use case OR any suggestion how we can include that (or do I need to integrate RapidJson myself into quicktype code).

Looking forward to your response.

samacumen avatar May 08 '24 09:05 samacumen