dependabot
Enabled RSpec InstanceVariable Rubocop rule.
https://www.rubydoc.info/gems/rubocop-rspec/RuboCop/Cop/RSpec/InstanceVariable
What are you trying to accomplish?
Enabling the RSpec/InstanceVariable Rubocop rule
Anything you want to highlight for special attention from reviewers?
Currenty, this is a draft PR. The first fix I made makes the test hang. I need to make more fixes but cannot proceed until I have this one working.
How will you know you've accomplished your goal?
Rubocop rules wil be enforced and the changes will be transparent on testing.
Checklist
- [x] I have run the complete test suite to ensure all tests and linters pass.
- [x] I have thoroughly tested my code changes to ensure they work as expected, including adding additional tests for new functionality.
- [x] I have written clear and descriptive commit messages.
- [x] I have provided a detailed description of the changes in the pull request, including the problem it addresses, how it fixes the problem, and any relevant details about the implementation.
- [x] I have ensured that the code is well-documented and easy to understand.
the go modules test seems to be having issues. If I fix one test, I break ten more. I will be taking more time on this in the morning.
The go_modules tests fai or pass depending on the order in which they are run. When the test scenarios starting with "without a clone of the repository..." are run anywhere but last, they seem to adversely affect the rest of the test cases. I suggest these tests shoud be reordered to last in order to make the changes not affect the other tests.
Garry has moved on from the :dependabot: team. It looks like the working bits of this PR were already extracted to:
- https://github.com/dependabot/dependabot-core/pull/10107
So I'll close this and review that one. Perhaps down the road someone will have bandwidth to tackle the remaining difficulties with the Go section of the tests.
