dependabot
Enabling RSpec AnyInstance
https://www.rubydoc.info/gems/rubocop-rspec/1.7.0/RuboCop/Cop/RSpec/AnyInstance
What are you trying to accomplish?
This pull request will enable the AnyInstance RSpec Rubocop rule.
Anything you want to highlight for special attention from reviewers?
Currently, this breaks all tests. This PR is put up for review so that people may assist me in fixing them. (This comment will be edited out before the final pul request is submitted.)
How will you know you've accomplished your goal?
Currently, the rubocop rule works, but the test should also run successfully.
Checklist
- [ ] I have run the complete test suite to ensure all tests and linters pass.
- [ ] I have thoroughly tested my code changes to ensure they work as expected, including adding additional tests for new functionality.
- [ ] I have written clear and descriptive commit messages.
- [ ] I have provided a detailed description of the changes in the pull request, including the problem it addresses, how it fixes the problem, and any relevant details about the implementation.
- [ ] I have ensured that the code is well-documented and easy to understand.
First pass was doing what was recommended. I am doing the second pass now, which will make the tests work. Third pass will be to ensure that the instance names are meaningful rather than using 'my_instance'.
Garry has moved on from the :dependabot: team. I suspect whoever tackles this next will start from a fresh PR, so I'm closing this.
