vets-website icon indicating copy to clipboard operation
vets-website copied to clipboard

VEBT-652 VYE - Modify BDN date logic

Open mghisilieri opened this issue 4 months ago • 0 comments

Are you removing, renaming or moving a folder in this PR?

  • [x] No, I'm not changing any folders (skip to TeamSites and delete the rest of this section)
  • [ ] Yes, I'm removing, renaming or moving a folder

Summary

  • If the delimiting date comes back as a 1900s date, it should be corrected to show as a 2000s date

Related issue(s)

  • https://jira.devops.va.gov/browse/VEBT-652

As a...

VYE Developer

I want…

To modify the BDN date logic

So that…

The date shown is accurate and not native to BDN logic

Acceptance Criteria

The Del date comes from BDN. Due to limitations of BDN, some of the DEL dates come in as "1900s". For example, if a user has a DEL date of 2027, BDN sends it as 1927. We need to make sure we are taking that date and showing it correctly. Show DEL date in the correct format. Change from 1900 to the 2000 equivalent. Example "1927" would be "2027"

Technical Details:

Dependencies: No

Feature Flag needed: No

Demo needed: No

UAT needed: No

Additional Notes:

Testing Details:

( X ) Quick Turn Around/Direct to Production

( ) Remains in Staging

( ) Staging Environment unavailable, coordinate w/ developer

Requested by and when:

Shay, 9/26

Definition of Done:

( n/a ) Demo/UAT completed with EDU

( ) Passed all internal testing in Staging

( ) Passed all internal testing in Production

( ) All work documented in Jira ticket

Testing done

  • VYE mock user data loaded for dates from both 1900s and 2000s to verify dates show properly for the Delimiting date field

Screenshots

Before:

Desktop (Before)

After:

Desktop (After)

What areas of the site does it impact?

  • VYE - Montgomery GI Bill enrollment verification

Acceptance criteria

Quality Assurance & Testing

  • [x] I fixed|updated|added unit tests and integration tests for each feature (if applicable).
  • [x] No sensitive information (i.e. PII/credentials/internal URLs/etc.) is captured in logging, hardcoded, or specs
  • [x] Linting warnings have been addressed
  • [ ] Documentation has been updated (link to documentation *if necessary)
  • [x] Screenshot of the developed feature is added
  • [ ] Accessibility testing has been performed

Error Handling

  • [x] Browser console contains no warnings or errors.
  • [ ] Events are being sent to the appropriate logging solution
  • [ ] Feature/bug has a monitor built into Datadog or Grafana (if applicable)

Authentication

  • [ ] Did you login to a local build and verify all authenticated routes work as expected with a test user

Requested Feedback

N/A

mghisilieri avatar Oct 10 '24 17:10 mghisilieri