vets-website
vets-website copied to clipboard
Ask-VA/1353-Caregiver Requirement
Are you removing, renaming or moving a folder in this PR?
- [X] No, I'm not changing any folders (skip to TeamSites and delete the rest of this section)
- [ ] Yes, I'm removing, renaming or moving a folder
Did you change site-wide styles, platform utilities or other infrastructure?
- [X] No
- [ ] Yes, and I used the proxy-rewrite steps to test the injected header scenario
Summary
- Require sign-in for Caregiver program on Who is your question about page
- (If bug, how to reproduce)
- (What is the solution, why is this the solution)
- Ask VA team owns the page/form.
- (If using a flipper, what is the end date of the flipper being required/success criteria being targeted)
Related issue(s)
- Ticekt: 1353
Testing done
- Did not require sign-in for caregiver program
- Creating request: Health care, Caregiver support program, Program of General Caregiver Support Services (PGCSS), Who is your question about? - Select "Myself" or "Someone else"
- Manual tests and Unit tests done.
- _Exclusively stating 'Specs and automated tests passing' is NOT acceptable as appropriate testing
Screenshots
UI did not change
What areas of the site does it impact?
Only impacts the Ask VA form
Acceptance criteria
Quality Assurance & Testing
- [X] I fixed|updated|added unit tests and integration tests for each feature (if applicable).
- [X] No sensitive information (i.e. PII/credentials/internal URLs/etc.) is captured in logging, hardcoded, or specs
- [X] Linting warnings have been addressed
- [ ] Documentation has been updated (link to documentation *if necessary)
- [ ] Screenshot of the developed feature is added
- [X] Accessibility testing has been performed
Error Handling
- [ ] Browser console contains no warnings or errors.
- [ ] Events are being sent to the appropriate logging solution
- [ ] Feature/bug has a monitor built into Datadog or Grafana (if applicable)
Authentication
- [X] Did you login to a local build and verify all authenticated routes work as expected with a test user