vets-website icon indicating copy to clipboard operation
vets-website copied to clipboard

preventing ITF failures causing a blocked sub

Open tblackwe opened this issue 9 months ago • 2 comments

Summary

For Forms 0995 and 526EZ, before a Veteran can create a claim, we check the status of their Intent to File and create one on the Veterans behalf if it fails.

If those API requests fail or timeout, the Veteran is prevented from continuing. This PR removes that block, and updates the messaging to the Veteran to be more clear.

Related issue(s)

  • Link to ticket created in va.gov-team repo https://github.com/department-of-veterans-affairs/va.gov-team/issues/82619

Testing done

  • Describe what the old behavior was prior to the change
    • If an error was triggered within ITF, the Veteran was not presented a Continue button.
  • Describe the steps required to verify your changes are working as expected
    • In local testing, authenticate and navigate to 526 or 995 flow, attempt to create claim, observe new info box and continue to claim
  • Describe the tests completed and the results
    • manually tested 526 and 995 on both mobile and desktop, continuing past info box to application
    • updated unit tests

Screenshots

Note: This field is mandatory for UI changes (non-component work should NOT have screenshots).

Before After
Mobile 526 image 526 image
image
995 image 995 image
Desktop 526 image 526 image
0995 image 0995 image

What areas of the site does it impact?

(Describe what parts of the site are impacted if code touched other areas)

Acceptance criteria

Quality Assurance & Testing

  • [x] I fixed|updated|added unit tests and integration tests for each feature (if applicable).
  • [x] No sensitive information (i.e. PII/credentials/internal URLs/etc.) is captured in logging, hardcoded, or specs
  • [x] Linting warnings have been addressed
  • [ ] Documentation has been updated (link to documentation *if necessary)
  • [x] Screenshot of the developed feature is added
  • [x] Accessibility testing has been performed

Error Handling

  • [x] Browser console contains no warnings or errors.
  • [x] Events are being sent to the appropriate logging solution
  • [ ] Feature/bug has a monitor built into Datadog or Grafana (if applicable)

Authentication

  • [x] Did you login to a local build and verify all authenticated routes work as expected with a test user

tblackwe avatar May 07 '24 21:05 tblackwe

I reviewed the codeclimate issues. They are valid concerns but fixing them is outside the scope of this ticket.

tblackwe avatar May 08 '24 18:05 tblackwe

Added Cypress e2e tests for Supplemental Claims & 526.

Note: I noticed minor differences in the ITF created alert title and the back navigation link vs button - I'm not sure if we need to be consistent.

Mottie avatar May 10 '24 14:05 Mottie