vets-website
vets-website copied to clipboard
VFEP-V3-search-input Implement v3 va-search-input in Search By Name tab.
Summary
- VFEP-V3-search-input Implement v3 va-search-input in Search By Name tab.
V3 Search Input
Imposter Component
Testing done
- Describe what the old behavior was prior to the change
- Describe the steps required to verify your changes are working as expected
- Describe the tests completed and the results
- _Exclusively stating 'Specs and automated tests passing' is NOT acceptable as appropriate testing
- Optionally, provide a link to your test plan and test execution records
Screenshots
Note: This field is mandatory for UI changes (non-component work should NOT have screenshots).
Before | After | |
---|---|---|
Mobile | ||
Desktop |
What areas of the site does it impact?
(Describe what parts of the site are impacted if code touched other areas)
Acceptance criteria
Quality Assurance & Testing
- [ ] I fixed|updated|added unit tests and integration tests for each feature (if applicable).
- [ ] No sensitive information (i.e. PII/credentials/internal URLs/etc.) is captured in logging, hardcoded, or specs
- [ ] Linting warnings have been addressed
- [ ] Documentation has been updated (link to documentation *if necessary)
- [ ] Screenshot of the developed feature is added
- [ ] Accessibility testing has been performed
Error Handling
- [ ] Browser console contains no warnings or errors.
- [ ] Events are being sent to the appropriate logging solution
- [ ] Feature/bug has a monitor built into Datadog or Grafana (if applicable)
Authentication
- [ ] Did you login to a local build and verify all authenticated routes work as expected with a test user
:warning: Team Sites (only applies to modifications made to the VA.gov header) :warning:
- [ ] The vets-website header does not contain any web-components
- [ ] I used the proxy-rewrite steps to test the injected header scenario
- [ ] I reached out in the
#sitewide-public-websites
Slack channel for questions
Requested Feedback
(OPTIONAL) What should the reviewers know in addition to the above. Is there anything specific you wish the reviewer to assist with. Do you have any concerns with this PR, why?