vets-api
vets-api copied to clipboard
Added get_transaction_status to new ProfileInformation::Service
Note: Delete the description statements, complete each step. None are optional, but can be justified as to why they cannot be completed as written. Provide known gaps to testing that may raise the risk of merging to production.
Summary
Created new ProfileInformation::Service to replace ContactInformation::Service. Added the transaction status to profile information
Changes:
1) get_transaction_status(http_verb, record)
replaces ContactInformation get_#{record_type}_transaction_status methods.
These methods in ContactInformation were repetitive. This provides less indirection.
Profile Information Issues
Questions for Auth Exper:
- handle_error is not working even though the 'common/client/errors' are required
Related issue(s)
- department-of-veterans-affairs/va.gov-team#83186
Testing done
- [x] New code is covered by unit tests
Screenshots
Note: Optional
What areas of the site does it impact?
- None, flipper is not on
Acceptance criteria
- [x] I fixed|updated|added unit tests and integration tests for each feature (if applicable).
- [x] No error nor warning in the console.
- [x] Events are being sent to the appropriate logging solution
- [x] Documentation has been updated (link to documentation)
- [x] No sensitive information (i.e. PII/credentials/internal URLs/etc.) is captured in logging, hardcoded, or specs
- [x] Feature/bug has a monitor built into Datadog (if applicable)
- [x] If app impacted requires authentication, did you login to a local build and verify all authenticated routes work as expected
- [x] I added a screenshot of the developed feature
Requested Feedback
(OPTIONAL)What should the reviewers know in addition to the above. Is there anything specific you wish the reviewer to assist with. Do you have any concerns with this PR, why?