vets-api icon indicating copy to clipboard operation
vets-api copied to clipboard

Created ProfileInformation Service

Open RachalCassity opened this issue 8 months ago • 1 comments

Note: Delete the description statements, complete each step. None are optional, but can be justified as to why they cannot be completed as written. Provide known gaps to testing that may raise the risk of merging to production.

Summary

Created new ProfileInformation::Service to replace ContactInformation::Service.

Changes: 1) create_or_update_info(http_verb, record) replaces ContactInformation put/post/update#{record} methods. The #{http_verb}_#{record} methods in ContactInformation were repetitive. Methods were added to VAProfile models.

Profile Information Issues

Questions for Auth Exper:

  1. Please check vcr paths: methods: :put or :post,
    uri: https://int.vet360.va.gov/profile-service/profile/v3/addresses

Related issue(s)

  • department-of-veterans-affairs/va.gov-team#83186

Testing done

  • [x] New code is covered by unit tests

Screenshots

Note: Optional

What areas of the site does it impact?

  • None, flipper is not on

Acceptance criteria

  • [x] I fixed|updated|added unit tests and integration tests for each feature (if applicable).
  • [x] No error nor warning in the console.
  • [x] Events are being sent to the appropriate logging solution
  • [x] Documentation has been updated (link to documentation)
  • [x] No sensitive information (i.e. PII/credentials/internal URLs/etc.) is captured in logging, hardcoded, or specs
  • [x] Feature/bug has a monitor built into Datadog (if applicable)
  • [x] If app impacted requires authentication, did you login to a local build and verify all authenticated routes work as expected
  • [x] I added a screenshot of the developed feature

Requested Feedback

(OPTIONAL)What should the reviewers know in addition to the above. Is there anything specific you wish the reviewer to assist with. Do you have any concerns with this PR, why?

RachalCassity avatar Jul 03 '24 16:07 RachalCassity