vets-api icon indicating copy to clipboard operation
vets-api copied to clipboard

Published 20 hours ago • verified publisher icon department-of-veterans-affairs

Resolve alias_attribute Deprecation Warnings

Open stevenjcumming opened this issue 9 months ago • 2 comments

Summary

  • Remove a deprecation warning from two files
    • app/models/form526_job_status.rb
    • app/models/saved_claim/disability_compensation.rb
  • switched to alias for Form526JobStatus
  • remove alias_attribute for SavedClaim::DisabilityCompensation because isn't used anymore
    • https://github.com/department-of-veterans-affairs/vets-api/pull/4039

Related issue(s)

  • https://github.com/department-of-veterans-affairs/va.gov-team/issues/83001

Testing done

  • [x] Run test suite locally

Acceptance criteria

  • [x] No alias_attribute deprecation warnings in the CI logs

stevenjcumming avatar May 13 '24 21:05 stevenjcumming

Error: A file (or its parent directories) does not have a CODEOWNERS entry. Please update the .github/CODEOWNERS file and add the entry for the Offending file: app/models/saved_claim/disability_compensation.rb

va-vsp-bot avatar May 13 '24 21:05 va-vsp-bot

Error: A file (or its parent directories) does not have a CODEOWNERS entry. Please update the .github/CODEOWNERS file and add the entry for the Offending file: app/models/saved_claim/disability_compensation.rb

va-vsp-bot avatar May 13 '24 22:05 va-vsp-bot