vets-api icon indicating copy to clipboard operation
vets-api copied to clipboard

API-34441 action poa request spike

Open nihil2501 opened this issue 9 months ago • 1 comments

just the basic bgs operation without much of the necessary surrounding infrastructure like validation picked up a couple restructures to share logic with poa request search already, with more coming

nihil2501 avatar May 08 '24 22:05 nihil2501

1 Warning
:warning: This PR changes 334 LoC (not counting whitespace/newlines).

In order to ensure each PR receives the proper attention it deserves, we recommend not exceeding
200. Expect some delays getting reviews.

File Summary

Files

  • modules/claims_api/app/clients/claims_api/bgs_client/service_action.rb (+14/-0)

  • modules/claims_api/app/controllers/claims_api/v2/power_of_attorney_request/base_controller.rb (+32/-0)

  • modules/claims_api/app/controllers/claims_api/v2/power_of_attorney_request/decisions_controller.rb (+39/-0)

  • modules/claims_api/app/controllers/claims_api/v2/power_of_attorney_requests_controller.rb (+11/-19)

  • modules/claims_api/app/services/claims_api/power_of_attorney_request_service/decide.rb (+41/-0)

  • modules/claims_api/app/services/claims_api/power_of_attorney_request_service/helpers/xml_builder.rb (+32/-0)

  • modules/claims_api/app/services/claims_api/power_of_attorney_request_service/search.rb (+14/-31)

  • modules/claims_api/config/routes.rb (+7/-1)

  • modules/claims_api/spec/requests/v2/power_of_attorney_requests/decline/request_spec.rb (+65/-0)

  • modules/claims_api/spec/requests/v2/power_of_attorney_requests/index/request_spec.rb (+12/-16)

    Note: We exclude files matching the following when considering PR size:

    *.csv, *.json, *.tsv, *.txt, Gemfile.lock, app/swagger, modules/mobile/docs, spec/fixtures/, spec/support/vcr_cassettes/, modules/mobile/spec/support/vcr_cassettes/, db/seeds, modules/vaos/app/docs, modules/meb_api/app/docs, modules/appeals_api/app/swagger/, *.bru
    

Big PRs are difficult to review, often become stale, and cause delays.

Generated by :no_entry_sign: Danger

github-actions[bot] avatar May 08 '24 22:05 github-actions[bot]