vets-api
vets-api copied to clipboard
department-of-veterans-affairs
VA-IIR 635: Add onboarding information to user serializer
Summary
Following the implementation of a feature toggle and model, this PR adds Onboarding data to the User Serializer so it can be included in the output of a request to /v0/user/
This work, along with the rest of the new Veteran Onboarding experience, lies behind the feature toggle, :veteran_onboarding_beta_flow. This project is owned by the VA-IIR team.
Related issue(s)
Additional tickets related to this project are located here
Testing done
This code is covered by unit tests for the Users Controller at /v0/users
What areas of the site does it impact?
/v0/users
Acceptance criteria
- [x] I added unit tests and integration tests for each feature (if applicable).
- [x] No error nor warning in the console.
- [ ] Events are being sent to the appropriate logging solution
- [ ] Documentation has been updated (link to documentation)
- x] No sensitive information (i.e. PII/credentials/internal URLs/etc.) is captured in logging, hardcoded, or specs
- [ ] Feature/bug has a monitor built into Datadog or Grafana (if applicable)
- [ ] If app impacted requires authentication, did you login to a local build and verify all authenticated routes work as expected
- [ ] I added a screenshot of the developed feature
Error: A file (or its parent directories) does not have a CODEOWNERS entry. Please update the .github/CODEOWNERS file and add the entry for the Offending file:
Error: A file (or its parent directories) was deleted but its reference still exists in CODEOWNERS. Please update the .github/CODEOWNERS file and delete the entry for the Offending file:
Error: A file (or its parent directories) was deleted but its reference still exists in CODEOWNERS. Please update the .github/CODEOWNERS file and delete the entry for the Offending file:
Error: A file (or its parent directories) does not have a CODEOWNERS entry. Please update the .github/CODEOWNERS file and add the entry for the Offending file:
Error: A file (or its parent directories) was deleted but its reference still exists in CODEOWNERS. Please update the .github/CODEOWNERS file and delete the entry for the Offending file:
Error: A file (or its parent directories) does not have a CODEOWNERS entry. Please update the .github/CODEOWNERS file and add the entry for the Offending file:
Hey @bosawt I'm requesting you as a reviewer on this PR because you were so helpful on my VeteranOnboarding model PR. If you're unavailable, that's cool! Thanks in advance.