vets-api icon indicating copy to clipboard operation
vets-api copied to clipboard

fix bugs from the simple froms migration

Open cloudmagic80 opened this issue 10 months ago • 4 comments

Summary

This PR is to fix a bug that was created during the migration from simple_forms folder to the ivc_champva folder. Some variables were not changed.

Related to: https://github.com/department-of-veterans-affairs/vets-api/pull/16091/files

Testing done

  • [ ] New code is covered by unit tests
  • Describe what the old behavior was prior to the change
  • Describe the steps required to verify your changes are working as expected. Exclusively stating 'Specs run' is NOT acceptable as appropriate testing
  • If this work is behind a flipper:
    • Tests need to be written for both the flipper on and flipper off scenarios. Docs.
    • What is the testing plan for rolling out the feature?

What areas of the site does it impact?

This only impacts the ivc_champava forms

Acceptance criteria

  • [ ] I fixed|updated|added unit tests and integration tests for each feature (if applicable).
  • [ ] No error nor warning in the console.
  • [ ] Events are being sent to the appropriate logging solution
  • [ ] Documentation has been updated (link to documentation)
  • [ ] No sensitive information (i.e. PII/credentials/internal URLs/etc.) is captured in logging, hardcoded, or specs
  • [ ] Feature/bug has a monitor built into Datadog or Grafana (if applicable)
  • [ ] If app impacted requires authentication, did you login to a local build and verify all authenticated routes work as expected
  • [ ] I added a screenshot of the developed feature

Requested Feedback

(OPTIONAL)What should the reviewers know in addition to the above. Is there anything specific you wish the reviewer to assist with. Do you have any concerns with this PR, why?

cloudmagic80 avatar Apr 19 '24 13:04 cloudmagic80

Error: A file (or its parent directories) does not have a CODEOWNERS entry. Please update the .github/CODEOWNERS file and add the entry for the Offending file: modules/ivc_champva/app/services/ivc_champva/pdf_filler.rb

va-vsp-bot avatar Apr 19 '24 13:04 va-vsp-bot

@cloudmagic80 not sure what happened in your latest commit, but there are zero files changed in this PR now 😕

rmtolmach avatar Apr 22 '24 13:04 rmtolmach

@cloudmagic80 I converted this to a draft. Mark it as ready for review once there's a diff to review.

rmtolmach avatar Apr 24 '24 12:04 rmtolmach

@cloudmagic80 Can this PR be closed?

RachalCassity avatar May 02 '24 17:05 RachalCassity

This PR is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 7 days.

github-actions[bot] avatar Jun 01 '24 18:06 github-actions[bot]

This PR has been closed because it has had no activity for 37 days

github-actions[bot] avatar Jun 08 '24 18:06 github-actions[bot]