vets-api icon indicating copy to clipboard operation
vets-api copied to clipboard

CH 31 Form Send to RES

Open tfink419 opened this issue 10 months ago • 5 comments

Summary

  • This work is behind a feature toggle (flipper): NO
  • Redirect ch31 form from VRE service to RES service

Related issue(s)

  • department-of-veterans-affairs/va.gov-team/issues/65386

Testing done

  • [x] New code is covered by unit tests
  • Have tested in staging/sandbox environments with code in console

What areas of the site does it impact?

Backend only redirect to new service to handle same form

Acceptance criteria

  • [x] I fixed|updated|added unit tests and integration tests for each feature (if applicable).
  • [x] No error nor warning in the console.
  • [x] Events are being sent to the appropriate logging solution
  • [x] Documentation has been updated (link to documentation)
  • [x] No sensitive information (i.e. PII/credentials/internal URLs/etc.) is captured in logging, hardcoded, or specs
  • [x] Feature/bug has a monitor built into Datadog or Grafana (if applicable)
  • [x] If app impacted requires authentication, did you login to a local build and verify all authenticated routes work as expected
  • [x] I added a screenshot of the developed feature

tfink419 avatar Apr 16 '24 17:04 tfink419

Error: A file (or its parent directories) does not have a CODEOWNERS entry. Please update the .github/CODEOWNERS file and add the entry for the Offending file: lib/res/ch31_form.rb

va-vsp-bot avatar Apr 16 '24 17:04 va-vsp-bot

1 Warning
:warning: This PR changes 466 LoC (not counting whitespace/newlines).

In order to ensure each PR receives the proper attention it deserves, we recommend not exceeding
200. Expect some delays getting reviews.

File Summary

Files

  • .github/CODEOWNERS (+2/-0)

  • app/models/saved_claim/veteran_readiness_employment_claim.rb (+68/-36)

  • app/sidekiq/vre/submit1900_job.rb (+3/-3)

  • config/features.yml (+4/-0)

  • config/settings.yml (+4/-0)

  • config/settings/test.yml (+4/-0)

  • lib/res/ch31_form.rb (+135/-0)

  • lib/res/configuration.rb (+30/-0)

  • lib/res/errors/ch31_errors.rb (+4/-0)

  • lib/res/service.rb (+34/-0)

  • spec/lib/res/ch31_form_spec.rb (+60/-0)

  • spec/models/saved_claim/veteran_readiness_employment_claim_spec.rb (+27/-49)

  • spec/sidekiq/vre/submit1900_job_spec.rb (+2/-1)

    Note: We exclude files matching the following when considering PR size:

    *.csv, *.json, *.tsv, *.txt, Gemfile.lock, app/swagger, modules/mobile/docs, spec/fixtures/, spec/support/vcr_cassettes/, modules/mobile/spec/support/vcr_cassettes/, db/seeds, modules/vaos/app/docs, modules/meb_api/app/docs, modules/appeals_api/app/swagger/, *.bru
    

Big PRs are difficult to review, often become stale, and cause delays.

Generated by :no_entry_sign: Danger

github-actions[bot] avatar Apr 16 '24 17:04 github-actions[bot]

Error: A file (or its parent directories) does not have a CODEOWNERS entry. Please update the .github/CODEOWNERS file and add the entry for the Offending file: lib/res/ch31_form.rb

va-vsp-bot avatar Apr 17 '24 17:04 va-vsp-bot

Error: A file (or its parent directories) does not have a CODEOWNERS entry. Please update the .github/CODEOWNERS file and add the entry for the Offending file: lib/res/ch31_form.rb

va-vsp-bot avatar Apr 24 '24 19:04 va-vsp-bot

Error: A file (or its parent directories) does not have a CODEOWNERS entry. Please update the .github/CODEOWNERS file and add the entry for the Offending file: lib/res/ch31_form.rb

va-vsp-bot avatar Apr 24 '24 23:04 va-vsp-bot