vets-api icon indicating copy to clipboard operation
vets-api copied to clipboard

46890 Service object for travel claim authentication

Open randomsync opened this issue 2 years ago • 1 comments

Description of change

This PR adds the service object and Redis client for calling the token endpoint of the VEIS auth service.

Original issue(s)

department-of-veterans-affairs/va.gov-team#46890

Things to know about this PR

  • There are changes to settings.yml that don't vary by environment. Related PRs:
    • department-of-veterans-affairs/devops/pull/12085
    • department-of-veterans-affairs/vsp-infra-application-manifests/pull/934
  • [x] rspec
  • [x] local testing

randomsync avatar Oct 10 '22 20:10 randomsync

1 Warning
:warning: This PR changes 246 LoC (not counting whitespace/newlines).

In order to ensure each PR receives the proper attention it deserves, we recommend not exceeding
200. Expect some delays getting reviews.

File Summary

Files

  • config/settings.yml (+3/-0)

  • modules/check_in/app/services/travel_claim/redis_client.rb (+35/-0)

  • modules/check_in/app/services/travel_claim/service.rb (+55/-0)

  • modules/check_in/config/initializers/statsd.rb (+7/-1)

  • modules/check_in/spec/services/travel_claim/redis_client_spec.rb (+87/-0)

  • modules/check_in/spec/services/travel_claim/service_spec.rb (+58/-0)

    Note: We exclude files matching the following when considering PR size:

    *.csv, *.json, *.tsv, *.txt, Gemfile.lock, app/swagger, modules/mobile/docs, spec/fixtures/, spec/support/vcr_cassettes/, modules/mobile/spec/support/vcr_cassettes/, db/seeds, modules/vaos/app/docs, modules/meb_api/app/docs, modules/appeals_api/app/swagger/
    

Big PRs are difficult to review, often become stale, and cause delays.

Generated by :no_entry_sign: Danger

github-actions[bot] avatar Oct 13 '22 18:10 github-actions[bot]