Hotfix/appeals 50829

[AimanK]

Resolves APPEALS-50829

Resource Links

• Jira Link: https://jira.devops.va.gov/browse/APPEALS-50829
• Building on this solution by Daniel Mage: https://github.com/department-of-veterans-affairs/caseflow/pull/20179

Description

Critical Defect: VSOs/Non-Board Attorneys should not see Judge CSS ID in search queues upon certain additional BVAAppealStatus conditions:

• Ready for Signature
• On Hold
• Misc
• Unknown
• Assigned to Attorney

Screenshots

Example of a case to be solved by this PR (PII is redacted):

Acceptance Criteria

VSO users/Private attorneys should not be able to view assigned_to_location details (CSS ID) during the following restricted statuses for appeals

• [x] Ready for Signature
• [x] On Hold
• [x] Misc
• [x] Unknown
• [x] Assigned to Attorney

Testing Plan

• [x] Test written and passing for all unit test cases
• [ ] Testing completed in UAT (with QA assistance)
• [ ] Testing completed in Prodtest (with QA assistance)

Test Coverage

Did you include any test coverage for your code? Check below:

• [x] RSpec

Code Climate

Your code does not add any new code climate offenses? If so why?

• [x] No new code climate issues added

Monitoring, Logging, Auditing, Error, and Exception Handling Checklist

Monitoring

• [x] Continuous monitoring in Dynatrace of Caseflow search endpoints during the deployment process