nrithner/APPEALS-45263

[nicorithner-bah]

Resolves Implement requested HLR/SC banner changes

Description

Implemented the logic to display or not display the "Compensation and Pension Benefits" message and "VHA Intake" user message under different scenarios in client/app/intake/pages/formGenerator.jsx.

• Scenario one. Non VHA user, with removeCompAndPenIntake feature toggle on, and vhaClaimReviewEstablishment feature toggle off. Displays only VHA message banner.
• Scenario two. Non VHA user, with both removeCompAndPenIntake and vhaClaimReviewEstablishment feature toggled on. Display both messages.
• Scenario Three. Non VHA user, with vhaClaimReviewEstablishment toggled off and removeCompAndPenIntake toggled on. Displays only the Compensation and Pension Benefits message.
• Scenario Four. VHA user, with vhaClaimReviewEstablishment toggled on and removeCompAndPenIntake toggled on. Displays only the Compensation and Pension Benefits message.

Tested this scenarios in spec/feature/intake/review_page_spec.rb

Acceptance Criteria

• [x] Implement changes based on approved UI/UX wireframes
• [x] Banner should show for VHA users
• [x] Non-VHA Users should see a banner with the original message and a new message
• [x] Banner will show when Feature Toggle is switched to on
• [x] Banner will not show when Feature Toggle is switched to off
• [x] Rspec's tests added to test feature toggle functionality
• [ ] Jest Tests are added to test UI Changes
• [x] All tests are passing
• [x] Code compiles correctly

Testing Plan

1. Go to Develop testing plan for removal of VBA intake in Caseflow UI or list them below

Frontend

User Facing Changes

• [ ] Screenshots of UI changes added to PR & Original Issue

BEFORE	AFTER

Tests

Test Coverage

Did you include any test coverage for your code? Check below:

• [x] RSpec
• [ ] Jest
• [ ] Other