vacuum-card icon indicating copy to clipboard operation
vacuum-card copied to clipboard

After updating to 2024.2.4 is the card empty

Open anders3408 opened this issue 11 months ago • 23 comments

Before submitting a bug

  • [x] I updated to the latest version available
  • [x] I cleared the cache of my browser

Describe the bug

After updating to 2024.2.4 is the card empty when adding it with the following yaml:

type: custom:vacuum-card
entity: vacuum.roomba

The model is a iRobot Roomba 980 and worked perfectly in version 2024.2.2 and in 2024.2.4 the iRobot works fine with other cards, but this looks much better :)

Steps to reproduce

  1. Go to '...'
  2. Click on '....'
  3. See error

Expected behavior A clear and concise description of what you expected to happen.

Screenshots If applicable, add screenshots to help explain your problem. For example, JavaScript errors are shown in the web inspector (if applicable).

Versions:

  • Release: Latest
  • Browser: Chrome, iOS app
  • HomeAssistant version: 2024.2.4

anders3408 avatar Feb 26 '24 22:02 anders3408

I restarted HA, disabled the Roomba, and re-enabled it and then the card displayed the vacuum again.

DeFlanko avatar Feb 27 '24 03:02 DeFlanko

I restarted HA, disabled the Roomba, and re-enabled it and then the card displayed the vacuum again.

Yes, this worked for me too

Veldkornet avatar Feb 27 '24 07:02 Veldkornet

This worked for me only for one time. The next time the card was not displayed again.

diveschumi avatar Feb 27 '24 14:02 diveschumi

This morning looks like i too now have this same issue -- the restart and disable and re-enable did not stick.

On Tue, Feb 27, 2024 at 6:34 AM diveschumi @.***> wrote:

This worked for me only for one time. The next time the card was not displayed again.

— Reply to this email directly, view it on GitHub https://github.com/denysdovhan/vacuum-card/issues/699#issuecomment-1966688127, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABH52MJL7QQ3XN346JORCB3YVXVHTAVCNFSM6AAAAABD3A2AJWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSNRWGY4DQMJSG4 . You are receiving this because you commented.Message ID: @.***>

-- Thanks, James

DeFlanko avatar Feb 27 '24 16:02 DeFlanko

I restarted HA, disabled the Roomba, and re-enabled it and then the card displayed the vacuum again.

Doesn't change anything here sadly.

anders3408 avatar Feb 27 '24 19:02 anders3408

I restarted HA, disabled the Roomba, and re-enabled it and then the card displayed the vacuum again.

Doesn't change anything here sadly.

Yeah, it has disappeared for me again

Veldkornet avatar Feb 27 '24 20:02 Veldkornet

For me the cards are only visible when vacuums are disabled(showing as unavailable), then after reenabling the vacuums cards are not visible

ethemcemozkan avatar Feb 27 '24 22:02 ethemcemozkan

Same problem here. The card is empty since the 2024.2.4 Update.

frontside76 avatar Feb 28 '24 05:02 frontside76

Same here after updating to 2024.2.4. After disabling/reenabling the integration the card is available, but after een brief period the card is empty again.

RamonM77 avatar Feb 28 '24 09:02 RamonM77

Just to say, same problem here 2024.2.4

sebPomme avatar Feb 28 '24 09:02 sebPomme

I'm having the same problem with ONE of two vacuums:

  1. An iRobot Roomba 980, the same as the OP.
    This machine does not show up in custom:vacuum-card since 2024.2.4 It appears like this in Developer Tools:
vacuum.roomba (State: docked)
battery_level: 30
battery_icon: mdi:battery-charging-20
software_version: v2.4.17-138
status: null
position: (208, -35, 8)
bin_present: true
bin_full: false
friendly_name: Roomba
supported_features: 13148
  1. A Eufy G30 Hybrid: Provided by a custom integration.
    This machine DOES still work with custom:vacuum-card:
vacuum.robovac
State: docked
fan_speed_list: Standard, Turbo, Max, Boost IQ
friendly_name: RoboVac
supported_features: 16252
battery_level: 100
battery_icon: mdi:battery-charging-100
cleaning_area: 43
cleaning_time: 5280
mode: Nosweep
friendly_name: RoboVac
supported_features: 16252

JBenson74 avatar Feb 28 '24 10:02 JBenson74

@denysdovhan is what happening over in this issue/hotfix affecting this card? https://github.com/home-assistant/core/issues/111210

DeFlanko avatar Feb 28 '24 16:02 DeFlanko

@denysdovhan is what happening over in this issue/hotfix affecting this card? home-assistant/core#111210

After last update 2024.2.4 Roomba and his entities are working again, but not the vaccuum card. The card is empty now.

frontside76 avatar Feb 28 '24 16:02 frontside76

+1, I'm unable to get the restart/disable/enable fix to work, but I've already restarted HA a few times.

MasterDevwi avatar Feb 28 '24 18:02 MasterDevwi

Disable/Enable fixes it if you're quick to open the effected dashboard while it's still unavailable, then it'll show card untill you refresh dashboard again. Something broke in this update.

DjRicko avatar Feb 29 '24 04:02 DjRicko

Can someone confirm if my changes on #702 will fix the issues to you as well? You can do that by temporarily using my fork ristomatti/vacuum-card by adding it to custom repositories. Just remember to change it back if/when the issue gets fixed here. :slightly_smiling_face:

ristomatti avatar Mar 01 '24 00:03 ristomatti

Can someone confirm if my changes on #702 will fix the issues to you as well? You can do that by temporarily using my fork ristomatti/vacuum-card by adding it to custom repositories. Just remember to change it back if/when the issue gets fixed here. 🙂

Worked for me. Thanks for the fix!

tom3q avatar Mar 01 '24 08:03 tom3q

Great job, thanks.

PetrP2B avatar Mar 01 '24 09:03 PetrP2B

That did the trick! Thanks 👍

RamonM77 avatar Mar 01 '24 12:03 RamonM77

This didn't work for me. My methodology was:

  • Clone ristomatti's repo and checkout bug/get-status-fails (commit 182afbe)
  • Run npm install and npm run build
  • Insert a comment on the top line of the resulting dist/vacuum-card.js to make sure it is getting downloaded
  • Create vacuum-card.js.gz from the newly created vacuum-card.js
  • Upload both of these to /config/www/community/vacuum-card/
  • CTRL+F5 and confirm the new file is downloaded using debug tools
  • Observe the vacuum cards for my Roomba's are still missing.

Are there any steps I'm missing?

kbarnes3 avatar Mar 02 '24 00:03 kbarnes3

@kbarnes3 Is the official vacuum card also loaded perhaps? Do you see any error on the devtools console? In my case it was pretty obvious:

    Uncaught (in promise) TypeError: Cannot read properties of null (reading 'toLowerCase')
        at qr.renderStatus (vacuum-card.js?hacstag=261291295280:4:14674)
        at qr.render (vacuum-card.js?hacstag=261291295280:4:17680)
        at qr.update (vacuum-card.js?hacstag=261291295280:1:15173)
        at qr.performUpdate (vacuum-card.js?hacstag=261291295280:1:6493)
        at qr.scheduleUpdate (vacuum-card.js?hacstag=261291295280:1:6140)
        at qr._$Ej (vacuum-card.js?hacstag=261291295280:1:6048)

I didn't try installing it manually, just went straight on creating a custom repo to see if the change worked. :grin:

ristomatti avatar Mar 02 '24 01:03 ristomatti

@ristomatti You are right, it looks like I had some weird caching going on. I updated the cache-busting number at the end of the Dashboard Resources settings and now I'm getting the new version and things look good again!

kbarnes3 avatar Mar 02 '24 01:03 kbarnes3

I was having issues adding custom repo too. I just removed the original vacuum card and manually downloaded the one from the fork, working fine now

Zackptg5 avatar Mar 02 '24 15:03 Zackptg5

Came looking for this very issue. Tried and confirmed that @ristomatti 's fork seems to resolve my issue (Roomba card empty, Shark card functional). Thank you! I see the Ukraine banner on this github project and notice that the original author doesn't appear to have been active for quite some time. Hopefully they're OK.

Ziris85 avatar Mar 05 '24 03:03 Ziris85

Can someone confirm if my changes on #702 will fix the issues to you as well? You can do that by temporarily using my fork ristomatti/vacuum-card by adding it to custom repositories. Just remember to change it back if/when the issue gets fixed here. 🙂

Got it back Thanks Coach!

image

DeFlanko avatar Mar 05 '24 04:03 DeFlanko

FYI @RamonM77 @petrepa @tom3q @Zackptg5 @DeFlanko @Ziris85 @kbarnes3, I can confirm this is now fixed with vacuum-card v2.8.1, please remove the custom repository. I'll keep it available for some time but eventually I'll delete it. Thank you for testing!

ristomatti avatar Mar 14 '24 16:03 ristomatti