duck-read-cache-fs
duck-read-cache-fs copied to clipboard
dentiny
Feature request: check a few TCP/HTTP parameters on IO performance
It's known that a few key metrics and parameters affecting IO performance a lot, including but not confined to:
- HTTP/2 or HTTP/1.1
- TCP connection number, i.e. do we create one TCP connection per request, or reuse them for multiple requests
- Latency for a request, max throughput extension could get
Given that the crash occurs due to a None object on this line: https://chromium.googlesource.com/chromium/tools/depot_tools.git/+/refs/heads/main/gclient_scm.py#:~:text=strp_current_url%20%3D%20current_url%5B%3A%2D4%5D%20if%20current_url.endswith(
...I have confirmed that the root cause of the crash is this change: https://chromium.googlesource.com/chromium/tools/depot_tools.git/+/eb0cb70185bf50f89b7b51beaf12c8d97009fdc5%5E%21/#F1:~:text=%2B%20%20%20%20%20%20%20%20if%20not%20scope%3A,values%3A%0A%2B%20%20%20%20%20%20%20%20%20%20%20%20return%20default?
The following patch works around the issue by checkout out a previous version of depot_tools which does NOT cause this error: https://github.com/chipilov/PyMiniRacer-depot_tools_patch/blob/depot_tools_patch/helpers/v8_build.py#L182
The root cause might need to be fixed in the depot_tools repo but maybe the version of depot_tools that is getting pulled here can be parameterized somehow OR fixed to a specific working version of depot_tools and updated only after being tested (instead of pulling the latest version every time)?
Hi and belated thanks for the diagnosis!
Pinning depot_tools would probably be useful. I would welcome a PR for this... probably we could simply hard-wire it in v8_build.py alongside the v8 version.
