vscode_deno icon indicating copy to clipboard operation
vscode_deno copied to clipboard

TypeScript outline still available in JS/TS while Deno extension is enabled

Open clo4 opened this issue 2 years ago • 3 comments

Describe the bug

The built-in TypeScript extension's file outline is still present while the Deno extension is active. I expected the TS extension's outline to be disabled since Deno provides the same data.

To Reproduce

  1. Open a JavaScript or TypeScript file with the extension active.
  2. Open the "Outline" panel.
  3. Observe the available outlines.

Expected behavior

The TypeScript extension's outline should not be present, since it's redundant.

Screenshots

image

Versions

vscode: 1.58.1 deno: 1.13.0 extension: 3.8.0

clo4 avatar Aug 13 '21 03:08 clo4

I've looked into this and it is somewhat challenging, because of the way the way it is acquired. #514 should fix it partially in certain situations, but there are times where Deno isn't aware that the diagnostics should be disabled, and so it allows them through, but then vscode doesn't do a full refresh, so they can't be suppressed. The only other choice is to assume Deno is enabled by default, which I think would cause a lot of other people frustration as they likely wouldn't get an outline for their non-Deno enabled projects.

kitsonk avatar Aug 31 '21 01:08 kitsonk

Wow, that sure is annoying. Thanks for looking into this!

I'm happy with that as a resolution, but it's also fine if you want to leave this issue open to track this for the future :)

clo4 avatar Sep 04 '21 06:09 clo4

It looks like this issue was run into the the Vue team with their Volar extension. They've included options on their site on how to configure your VS Code to remove the double outline.

See their notes here

MrPossumz avatar Dec 13 '22 19:12 MrPossumz