rusty_v8 icon indicating copy to clipboard operation
rusty_v8 copied to clipboard

Published 20 hours ago • verified publisher icon denoland

Integer::try_from() should work for all i64s

Open bnoordhuis opened this issue 3 years ago • 1 comments

v8::Integer::try_from(value) currently checks that value.is_int32() || value.is_uint32(), meaning the range is restricted to a subset of v8::Integer::value().

That's confusing/misleading/arguably wrong so I suggest we fix that.

bnoordhuis avatar Nov 25 '21 08:11 bnoordhuis

https://chromium-review.googlesource.com/c/v8/v8/+/3301467

bnoordhuis avatar Nov 25 '21 12:11 bnoordhuis