rusty_v8 icon indicating copy to clipboard operation
rusty_v8 copied to clipboard

Get link errors when upgrading rusty_v8

Open ry opened this issue 5 years ago • 2 comments

When I use rusty_v8 as a dependency and it gets upgrade, it doesn't seem to use the new librusty_v8.a because I get link errors if the ABI has changed.

For example, a recent upgrade of deno_core resulted in this error

  = note: Undefined symbols for architecture x86_64:
            "_v8__Isolate__CreateParams__SIZEOF", referenced from:
                _$LT$rusty_v8..isolate_create_params..raw..CreateParams$u20$as$u20$core..default..Default$GT$::default::h57323b37433ca0e9 in librusty_v8-2afbb5eb4a6bf179.rlib(rusty_v8-2afbb5eb4a6bf179.rusty_v8.8w61v7cb-cgu.3.rcgu.o)
            "_v8__Isolate__CreateParams__CONSTRUCT", referenced from:
                _$LT$rusty_v8..isolate_create_params..raw..CreateParams$u20$as$u20$core..default..Default$GT$::default::h57323b37433ca0e9 in librusty_v8-2afbb5eb4a6bf179.rlib(rusty_v8-2afbb5eb4a6bf179.rusty_v8.8w61v7cb-cgu.3.rcgu.o)
          ld: symbol(s) not found for architecture x86_64
          clang: error: linker command failed with exit code 1 (use -v to see invocation)

ry avatar May 18 '20 12:05 ry

That's correct, there's currently no logic in build.rs to update librusty_v8.a -- if it's there, it'll be used.

piscisaureus avatar May 20 '20 21:05 piscisaureus

I also get this error when trying to build librusty_v8_release_aarch64-linux-android.a, is there a way to avoid this error? Because I'm not familiar with V8. So it's not clear how to write ABI

deno v1.24.0 deno_v8 v0.48.0

waterbang avatar Aug 03 '22 01:08 waterbang