rusty_v8 icon indicating copy to clipboard operation
rusty_v8 copied to clipboard

perf: optimize ScopeData structure

Open littledivy opened this issue 1 year ago • 2 comments

18.6 ns per run 53.7 million ops/sec → new_ # main
16.4 ns per run 61.2 million ops/sec → new_ # patch

littledivy avatar Dec 01 '23 08:12 littledivy

Did I just bring back the Rust compiler bug we had earlier? 👀 https://github.com/denoland/rusty_v8/pull/1229

https://github.com/denoland/rusty_v8/actions/runs/7057713260/job/19212435294?pr=1370#step:11:7270

littledivy avatar Dec 01 '23 10:12 littledivy

Testing w/ASAN and opt-level=1. It's possible this is good to go and was just miscompiling.

mmastrac avatar Apr 12 '24 21:04 mmastrac