rusty_v8 icon indicating copy to clipboard operation
rusty_v8 copied to clipboard

Published 20 hours ago • verified publisher icon denoland

fix: fix make_pod static asserts

Open CGQAQ opened this issue 2 years ago • 2 comments

  • std::is_pod is deprecated in c++20 changed to std::is_standard_layout && std::is_trivial
  • V shoud be trivially_copyable in order to copy from

CGQAQ avatar Sep 07 '23 02:09 CGQAQ

CLA assistant check
All committers have signed the CLA.

CLAassistant avatar Sep 07 '23 02:09 CLAassistant

Seems like we are memcpying std::shared_ptr in the test, which is not safe I think

CGQAQ avatar Sep 08 '23 01:09 CGQAQ