fresh icon indicating copy to clipboard operation
fresh copied to clipboard

Published 20 hours ago • verified publisher icon denoland

useSignal on the starter counter.tsx

Open flemmingmiguel opened this issue 2 years ago • 1 comments

Having useSignal in the initial example could help adoption of it as the store for islands

flemmingmiguel avatar Sep 08 '22 09:09 flemmingmiguel

There is currently a bug in @preact/signals + preact-render-to-string that is resulting in a minor memory leak. I want to make sure this is fixed before we recommend that folks use signals.

lucacasonato avatar Sep 08 '22 10:09 lucacasonato

Is this still a bug? I wasn't able to find an issue on either @preact/signals or preact-render-to-string?

The closest thing I see is this issue: preact-render-to-string#191, but the timing doesn't make sense and it's closed anyways.

lino-levan avatar Oct 24 '22 15:10 lino-levan

I think that was before the 1.1 of Preact signals, I have the latest versions working with no issues and made a small PR to bump the dependencies of the starter project fresh#873

flemmingmiguel avatar Nov 01 '22 07:11 flemmingmiguel

I'll close this PR as it's being superseded by #1234. I'm sorry we didn't get to this earlier, @flemmingmiguel. Either way, thank you very much.

iuioiua avatar Jun 01 '23 02:06 iuioiua

Hey amazing to see the repo moving , was away for the past weeks due to some health issues, happy with the news that the framework is about to speed up

flemmingmiguel avatar Jun 17 '23 06:06 flemmingmiguel