fresh icon indicating copy to clipboard operation
fresh copied to clipboard

Disable VSCode experimental project setting

Open marcelocra opened this issue 3 years ago • 1 comments

Currently we get issues when running Deno in VSCode with the following setting enabled:

"typescript.tsserver.experimental.enableProjectDiagnostics": true

Details in denoland/vscode_deno#595.

This PR disables that setting in the workspace generated file, so that beginners won't stumble on this.

ps: Deno is amazing! Thank you, folks!

marcelocra avatar Sep 04 '22 18:09 marcelocra

@marcelocra It seems that some typescript plug-in configuration conflicts with DENO plug-in configuration.

If so, it's not reasonable for Fresh to add this configuration.

ahuigo avatar Sep 13 '22 09:09 ahuigo

@marcelocra It seems that some typescript plug-in configuration conflicts with DENO plug-in configuration.

If so, it's not reasonable for Fresh to add this configuration.

It seems reasonable if this is preventing Fresh users (particularly new ones) from enjoying a good dev experience. You already set a bunch of Deno default settings.

Of course this is up to you to accept. But it cost me a couple of hours to figure out.

marcelocra avatar Sep 17 '22 01:09 marcelocra

I agree that good dev experience is very important. Please wait for fresh's author to deal with your PR.

ahuigo avatar Sep 17 '22 07:09 ahuigo

I'm unable to reproduce this issue. Do you still have this issue, @marcelocra?

iuioiua avatar Jun 05 '23 06:06 iuioiua

Closing, because the issue was in typescript and it has been resolved on their side.

marvinhagemeister avatar Jun 21 '23 17:06 marvinhagemeister

Interestingly enough, I still need the "typescript.tsserver.experimental.enableProjectDiagnostics": false, for the squiglies to disappear. Am I missing something at this point?

marcelocra avatar Apr 01 '24 04:04 marcelocra