fresh icon indicating copy to clipboard operation
fresh copied to clipboard

plugin-tailwindcss: tailwind v4

Open AugustinMauroy opened this issue 10 months ago • 16 comments

close #2819

AugustinMauroy avatar Feb 23 '25 12:02 AugustinMauroy

@lucacasonato can I have help here there some issues with deno/workspace with my changes www shouldn't use tailwind 4 but it's do it. I'm not deno expert so could you take a look ?

Edit updating to Deno v2.2.2 fix issue

AugustinMauroy avatar Feb 26 '25 10:02 AugustinMauroy

@AugustinMauroy, can you publish this separately whilst we wait for it to get merged?

lishaduck avatar Feb 26 '25 21:02 lishaduck

@AugustinMauroy, can you publish this separately whilst we wait for it to get merged?

What do you mean ?

AugustinMauroy avatar Feb 27 '25 10:02 AugustinMauroy

@AugustinMauroy, can you publish this separately whilst we wait for it to get merged?

What do you mean ?

I mean, could you publish the @fresh/plugin-tailwind package to JSR as @AugustinMauroy/fresh-plugin-tailwind or whatever so it can be used until it gets merged?

lishaduck avatar Feb 27 '25 14:02 lishaduck

I mean, could you publish the @fresh/plugin-tailwind package to JSR as @AugustinMauroy/fresh-plugin-tailwind or whatever so it can be used until it gets merged? Your have: https://jsr.io/@pakornv/fresh-plugin-tailwindcss

But I saw you are learning web dev. So what I can recommend it's to wait official plugin.

AugustinMauroy avatar Feb 27 '25 15:02 AugustinMauroy

But I saw you are learning web dev. So what I can recommend it's to wait official plugin.

And where did you see that? I'd hardly say I'm still learning beyond that of the continuous learning needed to remain on the JS treadmill. I've been doing webdev for 5 years. According to the State of JS, that puts me around the median time for a web developer.

lishaduck avatar Feb 27 '25 15:02 lishaduck

of topic but your GH profile said that your are learning Preact/fresh

AugustinMauroy avatar Feb 27 '25 16:02 AugustinMauroy

of topic but your GH profile said that your are learning Preact/fresh

Oh, I haven't updated that in a while. I was learning it last year, now I feel fairly comfortable with it, I use it for most new web projects I do. Thanks for the reminder to update it!

lishaduck avatar Feb 27 '25 16:02 lishaduck

@lucacasonato need that to upgrade JSR to tailwind v4

AugustinMauroy avatar Apr 18 '25 09:04 AugustinMauroy

Yeah I'll check

AugustinMauroy avatar May 09 '25 08:05 AugustinMauroy

@SisyphusZheng i had fix WWW but test are failling I didn't get why it's falling

AugustinMauroy avatar May 09 '25 10:05 AugustinMauroy

  • ci / test (v2.x, macOS-latest) (pull_request)

Checkout the logs https://github.com/denoland/fresh/actions/runs/14926742379/job/41933249430?pr=2829

iuioiua avatar May 09 '25 10:05 iuioiua

@SisyphusZheng i had fix WWW but test are failling I didn't get why it's falling Maybe we need to check the logs and try running deno fmt and deno ok to debug the issue. And then we need to ensure that the v2.x CI/tests pass.

SisyphusZheng avatar May 09 '25 10:05 SisyphusZheng

it's should not because there are const FRESH_TAILWIND_VERSION = "0.0.1-alpha.7"; that explicitly said "use plugins made for tailwind v3"

AugustinMauroy avatar May 09 '25 10:05 AugustinMauroy

it's should not because there are const FRESH_TAILWIND_VERSION = "0.0.1-alpha.7"; that explicitly said "use plugins made for tailwind v3"

hello, I managed to make the modification work successfully based on your code, but only when node_modules is present. In the code you provided, the /www directory wasn't supported by the modified source code. Instead, it relied on the plugins previously built with Tailwind v3. When I tried to switch to using the provided plugin source code for support, it still didn't seem to work properly.

I checked the upstream plugin mentioned in #2819, which this plugin's code is based on, and found that it has the same issue as mine. It appears to only work correctly with node_modules support. Additionally, there are some discrepancies between that upstream plugin and our target requirements.

The specific problem I'm encountering now is what I mentioned in #2819.

SisyphusZheng avatar May 10 '25 16:05 SisyphusZheng

Humm it's seam be a deno issue. Because tailwind v4 need node_module. Because they've created a complete system for parsing and transforming css. Which is faster, but needs the node module. Because it uses native adon

AugustinMauroy avatar May 10 '25 20:05 AugustinMauroy

@marvinhagemeister, I think this has been superseded?

lishaduck avatar Jul 21 '25 15:07 lishaduck

Superseded by https://github.com/denoland/fresh/pull/3054

marvinhagemeister avatar Jul 21 '25 15:07 marvinhagemeister