fresh icon indicating copy to clipboard operation
fresh copied to clipboard

Button presses should not trigger zoom

Open oaustegard opened this issue 2 years ago • 4 comments

On the homepage at https://fresh.deno.dev/, viewed in Chrome on iOS iPhone 12, when tapping either of the Example’s plus or minus buttons repeatedly, if your tap speed hits the double-tap threshold the screen zooms unexpectedly to the width of the current number and the button you pressed. On zoom in the two increment/decrement presses are counted, then the zoom happens, on zoom out the zoom out happens first and “eats” the increment/decrement.

Both behaviors are surprising to a user and deserve a more consistent behavior.

oaustegard avatar Jun 18 '22 10:06 oaustegard

I'd be happy to take a PR to fix this. It seems like some oddity in Apple's Safari.

lucacasonato avatar Jun 18 '22 15:06 lucacasonato

Lemme take this up! 🚀

TommyDew42 avatar Jun 20 '22 11:06 TommyDew42

@lucacasonato

I am testing the change in my mobile device. Does fresh server by default listen to network request too? I don't seem to be able to connect to my local server from my mobile device.

TommyDew42 avatar Jun 21 '22 03:06 TommyDew42

@TommyDew42 It binds to localhost by default I think. You may need to explicitly bind to hostname: "0.0.0.0" (you can specify this as an option to start in //www/main.ts.

lucacasonato avatar Jun 21 '22 09:06 lucacasonato

This should probably be closed since #277 got merged.

lino-levan avatar Oct 19 '22 04:10 lino-levan

Closing, as this has been completed.

iuioiua avatar May 17 '23 00:05 iuioiua