fastwebsockets icon indicating copy to clipboard operation
fastwebsockets copied to clipboard

Zero unsafe usage

Open littledivy opened this issue 1 year ago • 1 comments

Eliminate unsafe code and examine dependencies that use it.

This should have never happened https://github.com/denoland/fastwebsockets/issues/42, my lazy oversight that gone unnoticed in Deno due to single thread usage but impacted other crate users.

littledivy avatar Feb 17 '24 06:02 littledivy

https://github.com/denoland/fastwebsockets/blob/70a4a98c3927b400d5db002441788799c9e58846/src/mask.rs#L107

littledivy avatar Feb 17 '24 06:02 littledivy

why is htis ocmpleted when the unsafe is still used there?

countradooku avatar Aug 15 '24 10:08 countradooku

afaik there is no safe alternative to it without making it slower

littledivy avatar Aug 15 '24 10:08 littledivy